You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Queued PR #383 overlaps the durable byte-store area. The clean order is to merge #383 first, then rebase this PR and verify every S3 client construction site receives the path-style setting. @16francej, can you confirm that landing order?
We're closing this PR. Per CONTRIBUTING.md, since coding agents write most of the underlying code now, we'd rather receive feature ideas as a short human-written note in adrs/ — informal is great, just the idea in your own words — and bugs as a plain issue. If we're aligned we're happy to burn our own tokens on the implementation, and we'll credit you as co-author.
We don't want your idea to get lost, so we've captured it in #802 to triage on our side. Please feel free to open an adrs/ note if you feel strongly about the approach. Appreciate you engaging with the repo!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S3_FORCE_PATH_STYLEruntime setting while preserving AWS defaultsTesting
node --test test/config.test.ts test/s3.test.ts test/blob-transfer.test.ts test/file-artifact-store.test.ts test/aws-sandbox.test.ts test/aws-deploy-provider.test.ts cli/test/fly-sandbox.test.tsnpm run typechecknpm run format:checknpm run lint -- --quietnpm run lint:oxgit diff --checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.