Skip to content

Support path-style S3 endpoints - #301

Closed
lijunwang2024-ship-it wants to merge 1 commit into
yc-software:mainfrom
lijunwang2024-ship-it:codex/s3-minio-path-style-20260809
Closed

Support path-style S3 endpoints#301
lijunwang2024-ship-it wants to merge 1 commit into
yc-software:mainfrom
lijunwang2024-ship-it:codex/s3-minio-path-style-20260809

Conversation

@lijunwang2024-ship-it

@lijunwang2024-ship-it lijunwang2024-ship-it commented Aug 9, 2026

Copy link
Copy Markdown

Summary

  • add an opt-in S3_FORCE_PATH_STYLE runtime setting while preserving AWS defaults
  • apply the setting to durable stores, AWS sandbox/deploy storage, and the Fly readiness probe
  • verify both virtual-host and path-style request serialization

Testing

  • node --test test/config.test.ts test/s3.test.ts test/blob-transfer.test.ts test/file-artifact-store.test.ts test/aws-sandbox.test.ts test/aws-deploy-provider.test.ts cli/test/fly-sandbox.test.ts
  • npm run typecheck
  • npm run format:check
  • npm run lint -- --quiet
  • npm run lint:ox
  • git diff --check

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@time-attack

Copy link
Copy Markdown
Collaborator

Queued PR #383 overlaps the durable byte-store area. The clean order is to merge #383 first, then rebase this PR and verify every S3 client construction site receives the path-style setting. @16francej, can you confirm that landing order?

@time-attack

Copy link
Copy Markdown
Collaborator

Thanks for this, @lijunwang2024-ship-it — and sorry for the slow response.

We're closing this PR. Per CONTRIBUTING.md, since coding agents write most of the underlying code now, we'd rather receive feature ideas as a short human-written note in adrs/ — informal is great, just the idea in your own words — and bugs as a plain issue. If we're aligned we're happy to burn our own tokens on the implementation, and we'll credit you as co-author.

We don't want your idea to get lost, so we've captured it in #802 to triage on our side. Please feel free to open an adrs/ note if you feel strongly about the approach. Appreciate you engaging with the repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants