qm init: pick one email transport and scaffold only its keys - #31
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ReganBell
force-pushed
the
init-email-transport
branch
from
July 30, 2026 21:13
f1282dc to
f194e93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A real deployment was confused by
qm initscaffolding both transports at once:.env.exampleofferedRESEND_API_KEYandSMTP_HOST/SMTP_USERNAME/SMTP_PASSWORDwhile the config silently defaulted to resend, so operators filled in the wrong set and only found out when sign-in emails never arrived.qm initnow takes--email-transport resend|smtp(default resend, matching the previous scaffold), mirroring the existing--model-providerflag pattern:env.auth.AUTH_EMAIL_TRANSPORTis set to the chosen transport (fly and aws scaffolds; docker has no auth service)renderEnvExampledrops catalog entries gated on the otherAUTH_EMAIL_TRANSPORTvalue, so the scaffolded.envand.env.examplecontain only the chosen transport's keys — the chosen transport's keys appear uncommented and requiredAUTH_EMAIL_TRANSPORTvalidation and the flag share oneEMAIL_TRANSPORTSdefinition inconfig.tsTests: new init case asserting
--email-transport smtpwrites a matching config withSMTP_*required and noRESEND_API_KEYanywhere in.env/.env.example, plus assertions that the default resend scaffold contains noSMTP_*keys.npm run typecheck, eslint, and oxlint clean; init/secrets/config/cli-dispatch/providers/auth-broker/setup suites pass (127/127).🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.