Drop the removed-features regression test - #36
Merged
Conversation
The suite pinned a hand-maintained list of retired paths, forbidden substrings and dead endpoints. It grew with every deletion, forced new work to launder strings through join() so ordinary prose would not trip the scanner, and mostly restated history that git already records. Live behaviour it touched is covered elsewhere: keychain upsert, rotation and revocation in test/keychain.test.ts, capability rejection paths in test/capability-routes.test.ts. The exception is the 403 for a capability token whose audience does not match the route, which no other test asserts today.
A capability token minted for another audience must not enter a self-service route. The only assertion of that 403 lived in the removed-features suite; it belongs next to the other capability rejection paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
test/removed-features.test.ts.The suite pinned a hand-maintained list of retired paths, forbidden substrings and dead endpoints. It grew with every deletion, forced new work to launder strings through
join()so ordinary prose would not trip the scanner, and mostly restated history that git already records.The second commit ports the one assertion worth keeping: a capability token whose
auddoes not match the route gets a 403. It now sits intest/capability-routes.test.tsalongside the other capability rejection paths (expired, wrong owner, non-self-service route).What goes away with the file, honestly stated:
.config/agent/credentials.envnever beats Keychain — rotation takes effect, deletion yieldsunset.test/keychain.test.tscovers upsert, rotation and revocation at the store level but not that precedence through a turn. Happy to port it if we want it kept.No other file references the deleted test,
npm run test:root:shard:checkstill enumerates every root test exactly once, and every symbol the deleted file imported still has other callers, soknipstays quiet.