Skip to content

Drop the removed-features regression test - #36

Merged
16francej merged 2 commits into
mainfrom
drop-removed-features-test
Jul 30, 2026
Merged

Drop the removed-features regression test#36
16francej merged 2 commits into
mainfrom
drop-removed-features-test

Conversation

@16francej

@16francej 16francej commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Removes test/removed-features.test.ts.

The suite pinned a hand-maintained list of retired paths, forbidden substrings and dead endpoints. It grew with every deletion, forced new work to launder strings through join() so ordinary prose would not trip the scanner, and mostly restated history that git already records.

The second commit ports the one assertion worth keeping: a capability token whose aud does not match the route gets a 403. It now sits in test/capability-routes.test.ts alongside the other capability rejection paths (expired, wrong owner, non-self-service route).

What goes away with the file, honestly stated:

  • the path and substring sentinels for retired subsystems — deliberate, that is the point of the PR
  • 404 assertions for nine retired endpoints (Wallet pairing, credential bootstrap/revoke/list, keychain import, webhooks, Gmail watches) — the routes do not exist, so 404 is the default, not a behaviour worth pinning
  • one real gap: an end-to-end check that a stale .config/agent/credentials.env never beats Keychain — rotation takes effect, deletion yields unset. test/keychain.test.ts covers upsert, rotation and revocation at the store level but not that precedence through a turn. Happy to port it if we want it kept.

No other file references the deleted test, npm run test:root:shard:check still enumerates every root test exactly once, and every symbol the deleted file imported still has other callers, so knip stays quiet.

The suite pinned a hand-maintained list of retired paths, forbidden
substrings and dead endpoints. It grew with every deletion, forced new
work to launder strings through join() so ordinary prose would not trip
the scanner, and mostly restated history that git already records.

Live behaviour it touched is covered elsewhere: keychain upsert,
rotation and revocation in test/keychain.test.ts, capability rejection
paths in test/capability-routes.test.ts. The exception is the 403 for a
capability token whose audience does not match the route, which no
other test asserts today.
A capability token minted for another audience must not enter a
self-service route. The only assertion of that 403 lived in the
removed-features suite; it belongs next to the other capability
rejection paths.
@16francej
16francej merged commit e00d3c0 into main Jul 30, 2026
15 checks passed
@16francej
16francej deleted the drop-removed-features-test branch July 30, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant