[codex] Preserve auth email allowlist with domain - #362
Open
time-attack wants to merge 2 commits into
Open
Conversation
time-attack
marked this pull request as ready for review
August 13, 2026 00:01
Collaborator
Author
|
The branch is mergeable, but GitHub currently shows only a skipped check. Before merging, please run the current CI matrix, complete live combined-domain/list authentication QA, and obtain the required fresh-context review. @16francej, are there any additional auth-policy cases you want covered? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328.
What changed
AUTH_ALLOWED_EMAILSoptional whenAUTH_ALLOWED_EMAIL_DOMAINis configured, so the CLI still sends it to auth and portalRoot cause
The conditional secret specs had no
optionalOtherwise, so a configured domain removedAUTH_ALLOWED_EMAILSfromcomputedSecretsinstead of making it optional. The portal also evaluated simultaneous list and domain rules as an intersection while the broker evaluated them as a union.Validation
node --test test/auth-broker.test.tsincli(8 passed)node --test test/oidc.test.tsinplugins/portal(14 passed)npm run typechecknpm run lintLive dev-instance QA was attempted, but no Slack pool app became available during the launcher's bounded wait, so no live instance was created.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.