Reject a run attempt whose lease was lost before completion - #386
Merged
Conversation
If an attempt's lease expired and the run was reclaimed by a newer attempt, the finishing stale attempt called the lease-fenced complete(), ignored its false result, and returned an ok reply anyway — reporting success for a run still executing under the new attempt. processRun now rejects when complete() returns false. The subsequent lease-fenced fail() with the stale token is a no-op, so the live attempt's claim, status, and result are untouched. Co-authored-by: Hawthorn <217181565+lamenting-hawthorn@users.noreply.github.com>
ReganBell
added a commit
that referenced
this pull request
Aug 13, 2026
If an attempt's lease expired and the run was reclaimed by a newer attempt, the finishing stale attempt called the lease-fenced complete(), ignored its false result, and returned an ok reply anyway — reporting success for a run still executing under the new attempt. processRun now rejects when complete() returns false. The subsequent lease-fenced fail() with the stale token is a no-op, so the live attempt's claim, status, and result are untouched. <!-- codesmith:footer --> --- <a href="https://app.blacksmith.sh/yc-software/codesmith/qm/pr/386"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a> <a href="https://backend.blacksmith.sh/track/enable-autofix?expires=1789237825&installation_model_id=19911&pr_number=386&repository=yc-software%2Fqm&return_to=https%3A%2F%2Fgithub.com%2Fyc-software%2Fqm%2Fpull%2F386&signature=e4b451a47672a0c69d4d9d2d9dda5fcce2fb8965bdc59e8a02527c3f079b9149"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a> <sup>Need help on this PR? Tag <code>@codesmith-bot</code> with what you need. Autofix is disabled.</sup> <!-- codesmith:autofix:disabled --> <!-- /codesmith:footer -->
ReganBell
added a commit
that referenced
this pull request
Aug 14, 2026
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a){kind=link}
The recent batch of squash merges lost their Co-authored-by trailers. This commit restores the credit. Per merged PR: - #381: @zlx, @leixf-lab - #382: @lamenting-hawthorn - #383: @lamenting-hawthorn - #385: @lamenting-hawthorn - #386: @lamenting-hawthorn - #387: @ianTPE - #402: @lamenting-hawthorn - #454: @paucommit - #470: @lamenting-hawthorn - #476: @lamenting-hawthorn, @Dhevenddra, @Saidheerajgollu, @mariohercules, @foxytanuki - #481: @Luke20w, @KateZhang98, @AdamSEY, @rsindall - #482: @lucassz - #494: @salluexez, @SomSamantray, @gregario, @yoldaolmak, @lamenting-hawthorn - #512: @wooheum-xin, @Jackallink, @ianTPE, @lmo-selected, @xieqian0816, @hugo2046 - #515: @mariohercules, @Luke20w, @tchudleigh1, @Restry Co-authored-by: adamsey <adam.lababidi@gmx.com> Co-authored-by: Dhevenddra <dhevg20020402@gmail.com> Co-authored-by: foxytanuki <biz@foxytanuki.dev> Co-authored-by: Greg Jackson <gregj64@gmail.com> Co-authored-by: hugo <shen.lan123@gmail.com> Co-authored-by: Ian Chou <33033541+ianTPE@users.noreply.github.com> Co-authored-by: Jackallink <61698219+Jackallink@users.noreply.github.com> Co-authored-by: KateZhang98 <kate@tinyfish.io> Co-authored-by: Hawthorn <rv.help23@gmail.com> Co-authored-by: leixf-lab <289300866+leixf-lab@users.noreply.github.com> Co-authored-by: lmo-selected <lmo-selected@users.noreply.github.com> Co-authored-by: lucassz <4793515+lucassz@users.noreply.github.com> Co-authored-by: Luke20w <weidnerluke@gmail.com> Co-authored-by: Mario <643672+mariohercules@users.noreply.github.com> Co-authored-by: Pau Garcia <193717438+paucommit@users.noreply.github.com> Co-authored-by: Restry <restry@users.noreply.github.com> Co-authored-by: rsindall <rsindall@users.noreply.github.com> Co-authored-by: Sai Dheeraj Gollu <saidheeraj.gollu@sjsu.edu> Co-authored-by: Mohd Salauddin <sallumalik1111@gmail.com> Co-authored-by: Som Samantray <92726151+SomSamantray@users.noreply.github.com> Co-authored-by: Tom <tchudleigh1@gmail.com> Co-authored-by: Wooheum Xin <xin98@naver.com> Co-authored-by: xieqian0816 <260077733+xieqian0816@users.noreply.github.com> Co-authored-by: yoldaolmak <159899613+yoldaolmak@users.noreply.github.com> Co-authored-by: Newell Zhu <zlx.star@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an attempt's lease expired and the run was reclaimed by a newer attempt, the finishing stale attempt called the lease-fenced complete(), ignored its false result, and returned an ok reply anyway — reporting success for a run still executing under the new attempt. processRun now rejects when complete() returns false. The subsequent lease-fenced fail() with the stale token is a no-op, so the live attempt's claim, status, and result are untouched.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.