web-ui: only offer session-drop targets that will really happen - #388
Merged
Conversation
Dragging a session onto the multiview canvas rendered all five drop zones (open-here plus four splits) unconditionally, with legitimacy decided only inside the drop handlers after the drop. So the UI advertised actions that wouldn't happen: at the pane cap a "Split" drop silently became a tab, and dragging a session already on the canvas showed full zones but any drop just focused its existing pane. The overlay now computes which targets are legitimate before rendering and only offers those, so what the user sees is what the drop will do. Tests cover the cap, the already-open session, and single-view cases.
ReganBell
added a commit
that referenced
this pull request
Aug 13, 2026
Dragging a session onto the multiview canvas rendered all five drop zones (open-here plus four splits) unconditionally, with legitimacy decided only inside the drop handlers after the drop. So the UI advertised actions that wouldn't happen: at the pane cap a "Split" drop silently became a tab, and dragging a session already on the canvas showed full zones but any drop just focused its existing pane. The overlay now computes which targets are legitimate before rendering and only offers those, so what the user sees is what the drop will do. Tests cover the cap, the already-open session, and single-view cases. **Deployment notes** Builds on the multiview pane work in #1885 (e06ba40af) — land that first or together Web-ui drag/drop UI logic only <!-- codesmith:footer --> --- <a href="https://app.blacksmith.sh/yc-software/codesmith/qm/pr/388"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a> <a href="https://backend.blacksmith.sh/track/enable-autofix?expires=1789237832&installation_model_id=19911&pr_number=388&repository=yc-software%2Fqm&return_to=https%3A%2F%2Fgithub.com%2Fyc-software%2Fqm%2Fpull%2F388&signature=255307e27382f83752dda99ea9a7cf5b6fc53bd872c7b581cb28061fe9f1e106"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a> <sup>Need help on this PR? Tag <code>@codesmith-bot</code> with what you need. Autofix is disabled.</sup> <!-- codesmith:autofix:disabled --> <!-- /codesmith:footer -->
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging a session onto the multiview canvas rendered all five drop zones (open-here plus four splits) unconditionally, with legitimacy decided only inside the drop handlers after the drop. So the UI advertised actions that wouldn't happen: at the pane cap a "Split" drop silently became a tab, and dragging a session already on the canvas showed full zones but any drop just focused its existing pane. The overlay now computes which targets are legitimate before rendering and only offers those, so what the user sees is what the drop will do. Tests cover the cap, the already-open session, and single-view cases.
Deployment notes
Builds on the multiview pane work in #1885 (e06ba40af) — land that first or together
Web-ui drag/drop UI logic only
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.