skills: Gmail helper calls the API via curl so it - #398
Merged
Conversation
* feat: surface named environments in admin Co-Authored-By: QM <qm@users.noreply.github.com> * refactor: clarify environment metadata response --------- Co-authored-by: Sprite <noreply@sprites.dev> Co-authored-by: QM <qm@users.noreply.github.com>
works behind an https CONNECT egress proxy The Gmail skill helper's HTTP layer used Python urllib, which cannot tunnel through an https:// CONNECT egress proxy, so in sandboxes routed through one every helper call failed and agents fell back to hand-rolled plain-text sends — losing the multipart/alternative HTML mirror and producing mail that recipients see re-wrapped at a narrow width. The helper's call() now shells out to curl, which tunnels CONNECT proxies natively; MIME construction is untouched, and non-2xx or non-JSON responses exit cleanly with the status and a body excerpt. Stub-curl tests assert the request shape (URL, auth header, JSON body over stdin), response parsing, and error behavior.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
works behind an https CONNECT egress proxy The Gmail skill helper's HTTP layer used Python urllib, which cannot tunnel through an https:// CONNECT egress proxy, so in sandboxes routed through one every helper call failed and agents fell back to hand-rolled plain-text sends — losing the multipart/alternative HTML mirror and producing mail that recipients see re-wrapped at a narrow width. The helper's call() now shells out to curl, which tunnels CONNECT proxies natively; MIME construction is untouched, and non-2xx or non-JSON responses exit cleanly with the status and a body excerpt. Stub-curl tests assert the request shape (URL, auth header, JSON body over stdin), response parsing, and error behavior.
Deployment notes
Release note: existing sandboxes keep the old gmail.py until re-provisioned/re-seeded
skills-seed script change only (gmail.py urllib→curl). New sandboxes get the fix at seed time;
boxes provisioned before the upgrade keep the stale copy until their skill tree is re-seeded — the
fork ran a manual sprite sweep for this; upstream needs a release note or an automatic re-seed
path for existing sandboxes.
Adds a runtime expectation that curl exists in the sandbox image (universally true in practice).
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.