deploy: publish pre-flight — inherit the entrypoint - #432
Closed
ReganBell wants to merge 1 commit into
Closed
Conversation
on redeploy, soft-skip unsupported backup Two avoidable ways a publish aborted. A redeploy that omitted entrypoint failed late, deep inside the deploy service, with "publish requires an entrypoint" — even though the deployment's previous version already had one; the entrypoint is now inherited from the current version, and with no prior version and none supplied the tool layer fails fast with a message that says what to pass. Separately, when the sandbox substrate doesn't support the optional backup step, the publish now skips it with a note instead of failing entirely. Tests cover inheritance, the fail-fast message, and the backup soft-skip. ⚠ BEFORE SENDING Fork PR body mentions substrate names and internal sweep tooling — rewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on redeploy, soft-skip unsupported backup Two avoidable ways a publish aborted. A redeploy that omitted entrypoint failed late, deep inside the deploy service, with "publish requires an entrypoint" — even though the deployment's previous version already had one; the entrypoint is now inherited from the current version, and with no prior version and none supplied the tool layer fails fast with a message that says what to pass. Separately, when the sandbox substrate doesn't support the optional backup step, the publish now skips it with a note instead of failing entirely. Tests cover inheritance, the fail-fast message, and the backup soft-skip.