Skip to content

Harden admin authorization readiness - #564

Merged
16francej merged 1 commit into
mainfrom
codex/fix-admin-probe-reliability
Aug 17, 2026
Merged

Harden admin authorization readiness#564
16francej merged 1 commit into
mainfrom
codex/fix-admin-probe-reliability

Conversation

@16francej

@16francej 16francej commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Retry and bound the admin surface's core authorization lookup, including final failure diagnostics.
  • Keep the portal's outer authorization probe alive long enough for that downstream retry budget.
  • Add a short-lived synthetic non-admin portal smoke check and run it from the portal workload during Fly and AWS live readiness checks.
  • Add regressions for the missed admin bootstrap boundary and both deployment runners.
  • Bump the CLI package to 1.0.6 because the deployment backends ship in @yc-software/qm.

Root cause

The previous retry protected only the portal's initial admin gate. After the shell loaded, the admin SPA called /admin/api/me, whose separate admin-to-core authorization lookup was one-shot and unbounded. A transient failure there produced the “Admin is temporarily unavailable” screen even though the portal gate had succeeded.

Deployment checks also stopped at generic health, ingress, and private core session checks, so they never traversed the public portal → admin → core authorization path.

Impact

Transient core failures during admin bootstrap are retried within a bounded budget. Persistent failures still fail closed, return the existing unavailable state, and now emit actionable diagnostics. Fly and AWS live checks will catch a broken public admin authorization chain without a real user session or a public bypass endpoint.

Validation

  • npm --prefix plugins/admin test — 79 passed
  • npm --prefix plugins/portal test — 109 passed
  • CLI test suite — 516 passed
  • npm run typecheck
  • admin and portal package typechecks
  • npm run lint
  • npm run format:check
  • Live local browser test with real portal and admin servers: the portal gate succeeded, the SPA's second authorization hop received a transient 502, retried, and rendered the signed-in Admin UI

@16francej
16francej force-pushed the codex/fix-admin-probe-reliability branch 3 times, most recently from 9b2056c to 1e36797 Compare August 17, 2026 18:07
@16francej
16francej force-pushed the codex/fix-admin-probe-reliability branch from 1e36797 to 78a42da Compare August 17, 2026 18:12
@16francej
16francej marked this pull request as ready for review August 17, 2026 18:17
@16francej
16francej merged commit 7733a1c into main Aug 17, 2026
21 checks passed
@16francej
16francej deleted the codex/fix-admin-probe-reliability branch August 17, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant