Harden admin authorization readiness - #564
Merged
Merged
Conversation
16francej
force-pushed
the
codex/fix-admin-probe-reliability
branch
3 times, most recently
from
August 17, 2026 18:07
9b2056c to
1e36797
Compare
16francej
force-pushed
the
codex/fix-admin-probe-reliability
branch
from
August 17, 2026 18:12
1e36797 to
78a42da
Compare
16francej
marked this pull request as ready for review
August 17, 2026 18:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@yc-software/qm.Root cause
The previous retry protected only the portal's initial admin gate. After the shell loaded, the admin SPA called
/admin/api/me, whose separate admin-to-core authorization lookup was one-shot and unbounded. A transient failure there produced the “Admin is temporarily unavailable” screen even though the portal gate had succeeded.Deployment checks also stopped at generic health, ingress, and private core session checks, so they never traversed the public portal → admin → core authorization path.
Impact
Transient core failures during admin bootstrap are retried within a bounded budget. Persistent failures still fail closed, return the existing unavailable state, and now emit actionable diagnostics. Fly and AWS live checks will catch a broken public admin authorization chain without a real user session or a public bypass endpoint.
Validation
npm --prefix plugins/admin test— 79 passednpm --prefix plugins/portal test— 109 passednpm run typechecknpm run lintnpm run format:check