fix(slack): deliver multi-file posts as one message with commentary - #657
Merged
Conversation
Slack uploads previously ran once per attachment with commentary posted separately, splitting related files across messages. All non-empty files now go out in a single upload call that carries the text as its comment, keeping files above commentary; surfaces needing post options the upload call cannot express fall back to the previous behavior. Returns an explicit uploaded flag and the shared message timestamp for callers. Co-authored-by: QM <noreply@ycombinator.com>
16francej
force-pushed
the
fix/slack-batch-attachments
branch
from
August 21, 2026 23:57
8bab1d3 to
17d9e06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack multi-file deliveries now upload all attachments in one call that carries the text as its comment, so related files land as a single message instead of separate posts. Surfaces that need post options the upload cannot express keep the previous separate-comment behavior.
node --test test/slack-attachments.test.ts test/slack-deliveries.test.ts— 28 passing; end-to-end twin run delivered one threaded message with two images + one text file and preserved commentaryNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.