Skip to content

Fix immutable MicroVM GitHub CLI install #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
16francej merged 1 commit into from
Aug 28, 2026
Merged

Fix immutable MicroVM GitHub CLI install #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions aws/microvm-agent/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ RUN dnf install -y \
&& setsid --version \
&& seq 1 1

RUN curl -fsSL https://cli.github.com/packages/rpm/gh-cli.repo \
-o /etc/yum.repos.d/gh-cli.repo \
&& dnf install -y gh-2.97.0-1 \
&& dnf clean all \
RUN GH_VERSION=2.97.0 \
&& GH_SHA256=73ea440ecad9c9e284429997ee6f93577bc6f7bc6fba357ef62c53ad8fb641a5 \
&& curl -fsSL "https://github.com/cli/cli/releases/download/v${GH_VERSION}/gh_${GH_VERSION}_linux_arm64.tar.gz" -o /tmp/gh.tgz \
&& echo "${GH_SHA256} /tmp/gh.tgz" | sha256sum -c - \
&& tar -xzf /tmp/gh.tgz -C /usr/local/bin --strip-components=2 "gh_${GH_VERSION}_linux_arm64/bin/gh" \
&& rm /tmp/gh.tgz \
&& gh --version

RUN curl -fsSL "https://awscli.amazonaws.com/awscli-exe-linux-aarch64-2.36.5.zip" -o /tmp/awscliv2.zip \
Expand Down
10 changes: 6 additions & 4 deletions cli/templates/aws/microvm-agent/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ RUN dnf install -y \
&& setsid --version \
&& seq 1 1

RUN curl -fsSL https://cli.github.com/packages/rpm/gh-cli.repo \
-o /etc/yum.repos.d/gh-cli.repo \
&& dnf install -y gh-2.97.0-1 \
&& dnf clean all \
RUN GH_VERSION=2.97.0 \
&& GH_SHA256=73ea440ecad9c9e284429997ee6f93577bc6f7bc6fba357ef62c53ad8fb641a5 \
&& curl -fsSL "https://github.com/cli/cli/releases/download/v${GH_VERSION}/gh_${GH_VERSION}_linux_arm64.tar.gz" -o /tmp/gh.tgz \
&& echo "${GH_SHA256} /tmp/gh.tgz" | sha256sum -c - \
&& tar -xzf /tmp/gh.tgz -C /usr/local/bin --strip-components=2 "gh_${GH_VERSION}_linux_arm64/bin/gh" \
&& rm /tmp/gh.tgz \
&& gh --version

RUN curl -fsSL "https://awscli.amazonaws.com/awscli-exe-linux-aarch64-2.36.5.zip" -o /tmp/awscliv2.zip \
Expand Down
10 changes: 9 additions & 1 deletion cli/test/microvm-dockerfile.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,15 @@ test("the canonical and packaged MicroVM Dockerfiles stay snapshot-safe and exec
);
assert.match(canonical, /^FROM public\.ecr\.aws\/lambda\/microvms:al2023-minimal@sha256:[a-f0-9]{64}$/m);
assert.match(canonical, /dnf install -y[\s\\]+curl-minimal\b/);
assert.match(canonical, /dnf install -y gh-\d+\.\d+\.\d+-\d+/);
assert.doesNotMatch(canonical, /cli\.github\.com\/packages\/rpm/);
assert.doesNotMatch(canonical, /dnf install -y gh-/);
assert.match(canonical, /GH_VERSION=\d+\.\d+\.\d+/);
assert.match(canonical, /GH_SHA256=[a-f0-9]{64}/);
assert.match(
canonical,
/github\.com\/cli\/cli\/releases\/download\/v\$\{GH_VERSION\}\/gh_\$\{GH_VERSION\}_linux_arm64\.tar\.gz/,
);
assert.match(canonical, /\$\{GH_SHA256\} {2}\/tmp\/gh\.tgz" \| sha256sum -c -/);
assert.match(canonical, /awscli-exe-linux-aarch64-\d+\.\d+\.\d+\.zip/);
assert.match(canonical, /[a-f0-9]{64} {2}\/tmp\/awscliv2\.zip" \| sha256sum -c -/);
assert.match(canonical, /rpm -q openssl-snapsafe-libs/);
Expand Down