fix: fix columns width on long rowset #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had a discussion with @adameat to analyze first 100 rows in order to calculate predicted width |
astandrik
force-pushed
the
astandrik.fix-columns-width-on-long-rowset-1340
branch
from
4a123ee
to
81874d6
Compare
artemmufazalov
requested changes
Oct 2, 2024
| columnType?: string; | ||
| }) => { | ||
| let maxColumnContentLength = name.length; | ||
| const headerPadding = columnType === 'number' ? 40 : 20; |
There was a problem hiding this comment.
What is headerPadding? Why it's different for numbers and other types?
Raubzeug
requested changes
Oct 2, 2024
| } | ||
| } | ||
|
|
||
| return Math.min(maxColumnContentLength * 10 + HEADER_PADDING, MAX_COLUMN_WIDTH); |
There was a problem hiding this comment.
it seems we may skip this check, cause it's already done: https://github.com/ydb-platform/ydb-embedded-ui/pull/1384/files#diff-372ca73fb142649c09d5b178debd37c1c6507e47eb54bf23cbf447d7f4904e1bR14
Raubzeug
approved these changes
Oct 2, 2024
artemmufazalov
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1340
Closes #1386
Closes #1387
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: ✅
Current: 79.13 MB | Main: 79.13 MB
Diff: +0.00 MB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information