Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: very bad performance when scrolling paginated tables #1513

Merged
merged 29 commits into from
Oct 28, 2024
Merged

fix: very bad performance when scrolling paginated tables #1513

merged 29 commits into from
Oct 28, 2024

Conversation

astandrik
Copy link
Contributor

@astandrik astandrik commented Oct 22, 2024 •
edited by github-actions bot
Loading

Closes #1472
Closes #1530

Stand

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
134 134 0 0 0

Bundle Size: 🔺

Current: 79.11 MB | Main: 79.10 MB
Diff: +0.01 MB (0.01%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik marked this pull request as draft October 22, 2024 13:01
@astandrik astandrik marked this pull request as ready for review October 23, 2024 16:55
artemmufazalov
artemmufazalov requested changes Oct 24, 2024
View reviewed changes
src/components/PaginatedTable/TableChunk.tsx Outdated Show resolved Hide resolved
src/components/PaginatedTable/PaginatedTable.tsx Outdated Show resolved Hide resolved
src/components/PaginatedTable/PaginatedTable.tsx Outdated Show resolved Hide resolved
src/components/PaginatedTable/PaginatedTable.tsx Outdated Show resolved Hide resolved
src/components/PaginatedTable/PaginatedTable.tsx Outdated Show resolved Hide resolved
src/components/PaginatedTable/utils.tsx Show resolved Hide resolved
src/components/PaginatedTable/PaginatedTable.tsx Outdated Show resolved Hide resolved
src/components/PaginatedTable/PaginatedTable.tsx Outdated Show resolved Hide resolved
artemmufazalov
artemmufazalov reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@artemmufazalov artemmufazalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ready to approve PR. Please remove test data from getNodes functions

Also I created 2 follow up issues:

  1. [PaginatedTable] improve performance with table groups #1546
  2. [PaginatedTable] remove scroll to top on filters change #1547

@astandrik astandrik added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit e2f7a25 Oct 28, 2024
4 of 6 checks passed
@astandrik astandrik deleted the astandrik.very-bad-performance-1472 branch October 28, 2024 13:58
@ydb-platform-bot ydb-platform-bot mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemmufazalov artemmufazalov artemmufazalov approved these changes

@Raubzeug Raubzeug Awaiting requested review from Raubzeug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@astandrik @artemmufazalov