Move MaxTxInFly to ICB #27635

neyrox · 2025-10-27T08:54:36Z

Changelog entry

Move MaxTxInFly to separate config TSystemTabletConfig

Changelog category

Improvement

Description for reviewers

(refactoring after #26783)

github-actions · 2025-10-27T08:57:28Z

🟢 2025-10-29 14:26:04 UTC The validation of the Pull Request description is successful.

github-actions · 2025-10-27T09:51:08Z

⚪ 2025-10-27 09:51:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6d76348 has started.
⚪ 2025-10-27 09:51:24 UTC Artifacts will be uploaded here
⚪ 2025-10-27 09:52:55 UTC ya make is running...
🟡 2025-10-27 12:34:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
41535	38737	0	7	2765	26

⚪ 2025-10-27 12:34:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-27 12:58:31 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
594 (only retried tests)	572	0	0	0	22

🟢 2025-10-27 12:58:34 UTC Build successful.
🟢 2025-10-27 12:58:52 UTC ydbd size 2.3 GiB changed* by +17.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `e569a87`	merge: `6d76348`	diff	diff %
ydbd size	2 436 863 248 Bytes	2 436 881 224 Bytes	+17.6 KiB	+0.001%
ydbd stripped size	518 032 264 Bytes	518 038 824 Bytes	+6.4 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-10-27T09:51:54Z

⚪ 2025-10-27 09:51:53 UTC Pre-commit check linux-x86_64-release-asan for 6d76348 has started.
⚪ 2025-10-27 09:52:09 UTC Artifacts will be uploaded here
⚪ 2025-10-27 09:53:34 UTC ya make is running...
🟡 2025-10-27 12:38:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18115	17658	0	206	232	19

🟢 2025-10-27 12:38:50 UTC Build successful.
🟢 2025-10-27 12:39:13 UTC ydbd size 3.8 GiB changed* by +29.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `e569a87`	merge: `6d76348`	diff	diff %
ydbd size	4 054 993 520 Bytes	4 055 023 424 Bytes	+29.2 KiB	+0.001%
ydbd stripped size	1 505 745 344 Bytes	1 505 759 520 Bytes	+13.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

kunga · 2025-10-27T12:22:06Z

ydb/core/base/appdata.cpp

    NKikimrConfig::TStatisticsConfig StatisticsConfig;
    TMetricsConfig MetricsConfig;
    NKikimrConfig::TSystemTabletBackupConfig SystemTabletBackupConfig;
+    NKikimrConfig::TSystemTabletConfig SystemTabletConfig;


я бы перенёс SystemTabletBackupConfig в SystemTabletConfig, например как поле BackupConfig

От этого же поедут существующие конфиги. По хорошему, переносы делаются так:

Заводим новые поля и связываем их со старыми

Старые объявляем deprecated

Ждем слудующей версии

Выдаем ошибку при использовании старых

Ждем следующей версии

Удаляем старые

В общем, ИМХО оно того не стоит в данном случае.

ладно, перенесём потом если поймем что можно

snaury · 2025-10-27T15:26:48Z

ydb/core/protos/config.proto

    optional TStatisticsConfig StatisticsConfig = 113;
    optional TMetricsConfig MetricsConfig = 114;
    optional TSystemTabletBackupConfig SystemTabletBackupConfig = 115;
+    optional TSystemTabletConfig SystemTabletConfig = 116;


Обсудили в личке, SystemTablet намекает, что это про "системные таблетки", которыми у нас принято называть кластерные таблетки типа bscontroller'а, schemeshard'а и т.д. Предложил перенести настройку в icb (рядом с MaxCommitRedoMB), чтобы её можно было в том числе в рантайме крутить.

github-actions · 2025-10-29T14:45:56Z

⚪ 2025-10-29 14:45:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for e164cb6 has started.
⚪ 2025-10-29 14:45:59 UTC Artifacts will be uploaded here
⚪ 2025-10-29 14:47:32 UTC ya make is running...
🟡 2025-10-29 17:00:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
41508	38686	0	2	2791	29

⚪ 2025-10-29 17:00:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-29 17:17:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
494 (only retried tests)	472	0	1	0	21

⚪ 2025-10-29 17:17:38 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-10-29 17:34:17 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
430 (only retried tests)	412	0	1	0	17

🟢 2025-10-29 17:34:20 UTC Build successful.
🟢 2025-10-29 17:34:38 UTC ydbd size 2.3 GiB changed* by +27.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `dfa9bb6`	merge: `e164cb6`	diff	diff %
ydbd size	2 427 879 840 Bytes	2 427 907 976 Bytes	+27.5 KiB	+0.001%
ydbd stripped size	517 665 576 Bytes	517 673 000 Bytes	+7.2 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-10-29T14:49:26Z

⚪ 2025-10-29 14:49:26 UTC Pre-commit check linux-x86_64-release-asan for e164cb6 has started.
⚪ 2025-10-29 14:49:29 UTC Artifacts will be uploaded here
⚪ 2025-10-29 14:50:52 UTC ya make is running...
🟡 2025-10-29 17:31:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18056	17613	0	209	214	20

🟢 2025-10-29 17:31:19 UTC Build successful.
🟢 2025-10-29 17:31:41 UTC ydbd size 3.8 GiB changed* by +18.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `ad8b580`	merge: `e164cb6`	diff	diff %
ydbd size	4 063 827 616 Bytes	4 063 846 112 Bytes	+18.1 KiB	+0.000%
ydbd stripped size	1 509 865 624 Bytes	1 509 873 656 Bytes	+7.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-10-30T08:50:34Z

⚪ 2025-10-30 08:50:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 780d485 has started.
⚪ 2025-10-30 08:50:51 UTC Artifacts will be uploaded here
⚪ 2025-10-30 08:52:18 UTC ya make is running...
🟡 2025-10-30 11:05:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
41513	38685	0	7	2793	28

⚪ 2025-10-30 11:05:31 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-30 11:23:11 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
595 (only retried tests)	575	0	0	0	20

🟢 2025-10-30 11:23:16 UTC Build successful.
🟢 2025-10-30 11:23:32 UTC ydbd size 2.3 GiB changed* by +8.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fc69c51`	merge: `780d485`	diff	diff %
ydbd size	2 428 004 736 Bytes	2 428 013 880 Bytes	+8.9 KiB	+0.000%
ydbd stripped size	517 690 088 Bytes	517 691 560 Bytes	+1.4 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-10-30T08:51:06Z

⚪ 2025-10-30 08:51:05 UTC Pre-commit check linux-x86_64-release-asan for 780d485 has started.
⚪ 2025-10-30 08:51:21 UTC Artifacts will be uploaded here
⚪ 2025-10-30 08:52:43 UTC ya make is running...
🟡 2025-10-30 11:36:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18061	17634	0	192	209	26

🟢 2025-10-30 11:36:47 UTC Build successful.
🟢 2025-10-30 11:37:09 UTC ydbd size 3.8 GiB changed* by +18.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fc69c51`	merge: `780d485`	diff	diff %
ydbd size	4 064 020 512 Bytes	4 064 039 000 Bytes	+18.1 KiB	+0.000%
ydbd stripped size	1 509 934 072 Bytes	1 509 942 104 Bytes	+7.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions bot added the improvement label Oct 27, 2025

Move MaxTxInFly to separate config

1ce5967

neyrox force-pushed the move-max-tx-in-fly branch from 73e0fe8 to 1ce5967 Compare October 27, 2025 09:47

kunga reviewed Oct 27, 2025

View reviewed changes

neyrox marked this pull request as ready for review October 27, 2025 13:56

neyrox requested a review from a team as a code owner October 27, 2025 13:56

neyrox requested a review from kunga October 27, 2025 14:04

kunga previously approved these changes Oct 27, 2025

View reviewed changes

neyrox requested review from azevaykin and snaury October 27, 2025 14:22

snaury reviewed Oct 27, 2025

View reviewed changes

Move MaxTxInFly to Immediate Control Board

98f3fb0

neyrox dismissed kunga’s stale review via 98f3fb0 October 29, 2025 14:12

neyrox changed the title ~~Move MaxTxInFly to separate config~~ Move MaxTxInFly to ICB Oct 29, 2025

github-actions bot added improvement and removed improvement labels Oct 29, 2025

Rollback obsolete changes

cfd6180

Remove extra spaces

eb8134e

neyrox enabled auto-merge (squash) October 30, 2025 11:42

neyrox requested review from kunga and snaury October 30, 2025 11:42

snaury approved these changes Oct 30, 2025

View reviewed changes

neyrox merged commit a547ff3 into ydb-platform:main Oct 30, 2025
10 checks passed

neyrox added a commit to neyrox/ydb that referenced this pull request Oct 31, 2025

Move MaxTxInFly to ICB (ydb-platform#27635)

b0cb7a3

neyrox mentioned this pull request Oct 31, 2025

Stable-25-3 Reject Probability in Column Shards #28077

Draft

Move MaxTxInFly to ICB #27635

Move MaxTxInFly to ICB #27635

Uh oh!

Conversation

neyrox commented Oct 27, 2025

Changelog entry

Changelog category

Description for reviewers

Uh oh!

github-actions bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kunga Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

neyrox Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

neyrox Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

kunga Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

snaury Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Oct 27, 2025 •

edited

Loading

github-actions bot commented Oct 27, 2025 •

edited

Loading

github-actions bot commented Oct 27, 2025 •

edited

Loading

neyrox Oct 27, 2025 •

edited

Loading

snaury Oct 27, 2025 •

edited

Loading

github-actions bot commented Oct 29, 2025 •

edited

Loading

github-actions bot commented Oct 29, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading