Skip to content

Conversation

@Enjection
Copy link
Member

@Enjection Enjection commented Oct 27, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

🟢 2025-10-29 09:59:36 UTC The validation of the Pull Request description is successful.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@Enjection Enjection requested a review from CyberROFL October 29, 2025 09:25
@Enjection Enjection marked this pull request as ready for review October 29, 2025 09:25
@Enjection Enjection requested a review from a team as a code owner October 29, 2025 09:25
Comment on lines +69 to +71
bool omitIndexes = bc->Description.HasOmitIndexes()
? bc->Description.GetOmitIndexes()
: false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool omitIndexes = bc->Description.HasOmitIndexes()
? bc->Description.GetOmitIndexes()
: false;
const bool omitIndexes = bc->Description.HasOmitIndexes() && bc->Description.GetOmitIndexes();

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

2025-10-29 09:58:18 UTC Pre-commit check linux-x86_64-release-asan for 13c044c has started.
2025-10-29 09:58:36 UTC Artifacts will be uploaded here
2025-10-29 10:00:06 UTC ya make is running...
🟡 2025-10-29 12:49:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18067 17480 0 277 292 18

🟢 2025-10-29 12:49:56 UTC Build successful.
🟢 2025-10-29 12:50:21 UTC ydbd size 3.8 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f361531 merge: 13c044c diff diff %
ydbd size 4 063 244 720 Bytes 4 063 247 872 Bytes +3.1 KiB +0.000%
ydbd stripped size 1 509 631 736 Bytes 1 509 633 016 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

2025-10-29 09:58:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 13c044c has started.
2025-10-29 09:58:38 UTC Artifacts will be uploaded here
2025-10-29 10:00:07 UTC ya make is running...
🟡 2025-10-29 12:21:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41519 38671 0 8 2807 33

2025-10-29 12:21:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-29 12:43:31 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
804 (only retried tests) 778 0 0 6 20

🟢 2025-10-29 12:43:33 UTC Build successful.
🟢 2025-10-29 12:43:51 UTC ydbd size 2.3 GiB changed* by +1.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f361531 merge: 13c044c diff diff %
ydbd size 2 427 610 680 Bytes 2 427 612 264 Bytes +1.5 KiB +0.000%
ydbd stripped size 517 613 768 Bytes 517 614 088 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Enjection Enjection linked an issue Oct 29, 2025 that may be closed by this pull request
@Enjection Enjection merged commit 9eb6468 into ydb-platform:main Oct 29, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Full backup w/ indexes for backup collections

2 participants