Skip to content

Conversation

@n00bcracker
Copy link
Collaborator

@n00bcracker n00bcracker commented Oct 27, 2025

Changelog entry

To increase isolation of different databases and prevent lookups from one to another we have to fill database name in SchemeCache.
Therefore I added passing database name through Datashard batch upload requests.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

🟢 2025-10-28 19:06:19 UTC The validation of the Pull Request description is successful.

@n00bcracker n00bcracker force-pushed the fill_db_name_in_scheme_cache_requests-3 branch from c6d1b26 to 1f325cc Compare October 27, 2025 21:17
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 27, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 27, 2025
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@n00bcracker n00bcracker self-assigned this Oct 28, 2025
@n00bcracker n00bcracker force-pushed the fill_db_name_in_scheme_cache_requests-3 branch 2 times, most recently from e5e23c5 to 6492a82 Compare October 28, 2025 12:10
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 28, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 28, 2025
@n00bcracker n00bcracker force-pushed the fill_db_name_in_scheme_cache_requests-3 branch from 6492a82 to 0100182 Compare October 28, 2025 13:45
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 28, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 28, 2025
@github-actions
Copy link

github-actions bot commented Oct 28, 2025

2025-10-28 13:49:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0d211d4 has started.
2025-10-28 13:49:46 UTC Artifacts will be uploaded here
2025-10-28 13:51:10 UTC ya make is running...
🟡 2025-10-28 15:48:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41479 38651 0 8 2792 28

2025-10-28 15:49:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-28 16:13:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1034 (only retried tests) 1015 0 1 0 18

2025-10-28 16:13:03 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-28 16:26:09 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
426 (only retried tests) 410 0 0 0 16

🟢 2025-10-28 16:26:16 UTC Build successful.
🟢 2025-10-28 16:26:35 UTC ydbd size 2.3 GiB changed* by +58.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 83f6d8a merge: 0d211d4 diff diff %
ydbd size 2 427 340 768 Bytes 2 427 400 696 Bytes +58.5 KiB +0.002%
ydbd stripped size 517 566 728 Bytes 517 579 496 Bytes +12.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

2025-10-28 13:49:54 UTC Pre-commit check linux-x86_64-release-asan for 0d211d4 has started.
2025-10-28 13:50:13 UTC Artifacts will be uploaded here
2025-10-28 13:51:39 UTC ya make is running...
🟡 2025-10-28 16:04:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18027 17623 0 174 210 20

🟢 2025-10-28 16:05:05 UTC Build successful.
🟢 2025-10-28 16:05:29 UTC ydbd size 3.8 GiB changed* by +84.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 83f6d8a merge: 0d211d4 diff diff %
ydbd size 4 062 762 600 Bytes 4 062 849 040 Bytes +84.4 KiB +0.002%
ydbd stripped size 1 509 476 504 Bytes 1 509 503 096 Bytes +26.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@n00bcracker n00bcracker marked this pull request as ready for review October 28, 2025 19:18
@n00bcracker n00bcracker requested review from a team as code owners October 28, 2025 19:18
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лишний дифф.

Copy link
Collaborator

@nikvas0 nikvas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kqp ok

@n00bcracker n00bcracker removed the request for review from Alek5andr-Kotov October 29, 2025 11:49
@n00bcracker n00bcracker merged commit c6f531a into ydb-platform:main Oct 29, 2025
16 checks passed
@n00bcracker n00bcracker deleted the fill_db_name_in_scheme_cache_requests-3 branch October 29, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants