Skip to content

Conversation

@dcherednik
Copy link
Member

Changelog entry

Move iterconnect_address in to separate lib.
The NInterconnect::TAddress code is used inside RDMA code. We need to move it in to separate library to prevent cycle dependence interconnect -> rdma -> interconnect

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

🟢 2025-10-27 16:52:26 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

2025-10-27 16:30:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for ae209ba has started.
2025-10-27 16:30:33 UTC Artifacts will be uploaded here
2025-10-27 16:31:48 UTC ya make is running...
🟢 2025-10-27 16:31:53 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-10-27 16:31:56 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

2025-10-27 16:30:50 UTC Pre-commit check linux-x86_64-release-asan for ae209ba has started.
2025-10-27 16:31:03 UTC Artifacts will be uploaded here
2025-10-27 16:32:19 UTC ya make is running...
🟢 2025-10-27 16:32:25 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-10-27 16:32:27 UTC Build successful.

@dcherednik dcherednik changed the title [ICRDMA] Move iterconnect_address in to separate lib NBYDB-1068 [ICRDMA] Move iterconnect_address in to separate lib EXT-1068 Oct 27, 2025
@dcherednik dcherednik requested a review from a team as a code owner October 27, 2025 16:53
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

2025-10-27 16:57:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7ccc890 has started.
2025-10-27 16:57:24 UTC Artifacts will be uploaded here
2025-10-27 16:58:48 UTC ya make is running...
🟡 2025-10-27 18:40:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41614 38782 0 4 2794 34

2025-10-27 18:40:51 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-27 18:59:46 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
605 (only retried tests) 585 0 0 0 20

🟢 2025-10-27 18:59:49 UTC Build successful.
🟢 2025-10-27 19:00:05 UTC ydbd size 2.3 GiB changed* by -1.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ea44658 merge: 7ccc890 diff diff %
ydbd size 2 440 226 480 Bytes 2 440 225 008 Bytes -1.4 KiB -0.000%
ydbd stripped size 518 955 016 Bytes 518 954 760 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

2025-10-27 16:57:32 UTC Pre-commit check linux-x86_64-release-asan for 7ccc890 has started.
2025-10-27 16:57:46 UTC Artifacts will be uploaded here
2025-10-27 16:59:09 UTC ya make is running...
🟡 2025-10-27 19:07:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17937 17466 0 227 222 22

🟢 2025-10-27 19:07:21 UTC Build successful.
🟢 2025-10-27 19:07:44 UTC ydbd size 3.8 GiB changed* by -2.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ea44658 merge: 7ccc890 diff diff %
ydbd size 4 061 030 200 Bytes 4 061 027 808 Bytes -2.3 KiB -0.000%
ydbd stripped size 1 508 769 024 Bytes 1 508 768 064 Bytes -960 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik enabled auto-merge (squash) October 27, 2025 17:44
@dcherednik dcherednik merged commit b5b0c50 into ydb-platform:main Oct 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants