Skip to content

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Oct 27, 2025

Changelog entry

Fix quorum calculation logic

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This patch makes more relaxed distconf quorum calculation allowing adding and removing hosts safely.

@alexvru alexvru force-pushed the distconf/fix-quorums branch 2 times, most recently from 2117093 to 32ef605 Compare October 27, 2025 18:00
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

2025-10-27 18:01:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 166ae45 has started.
2025-10-27 18:01:39 UTC Artifacts will be uploaded here
2025-10-27 18:04:10 UTC ya make is running...
🟡 2025-10-27 19:45:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39281 36459 0 10 2787 25

2025-10-27 19:45:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-27 20:07:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
468 (only retried tests) 445 0 1 0 22

2025-10-27 20:07:15 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-27 20:32:18 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
430 (only retried tests) 407 0 0 0 23

🟢 2025-10-27 20:32:21 UTC Build successful.
🟢 2025-10-27 20:32:41 UTC ydbd size 2.3 GiB changed* by -608 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: ea44658 merge: 166ae45 diff diff %
ydbd size 2 440 226 480 Bytes 2 440 225 872 Bytes -608 Bytes -0.000%
ydbd stripped size 518 955 016 Bytes 518 954 952 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

🟢 2025-10-27 18:02:34 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

2025-10-27 18:04:17 UTC Pre-commit check linux-x86_64-release-asan for 166ae45 has started.
2025-10-27 18:04:31 UTC Artifacts will be uploaded here
2025-10-27 18:05:52 UTC ya make is running...
🟡 2025-10-27 20:01:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15718 15317 0 174 213 14

🟢 2025-10-27 20:01:50 UTC Build successful.
🟢 2025-10-27 20:02:13 UTC ydbd size 3.8 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: ea44658 merge: 166ae45 diff diff %
ydbd size 4 061 030 200 Bytes 4 061 030 216 Bytes +16 Bytes +0.000%
ydbd stripped size 1 508 769 024 Bytes 1 508 768 960 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru force-pushed the distconf/fix-quorums branch from 32ef605 to cb9b63a Compare October 28, 2025 13:46
@github-actions
Copy link

github-actions bot commented Oct 28, 2025

2025-10-28 13:51:06 UTC Pre-commit check linux-x86_64-release-asan for c6c1fec has started.
2025-10-28 13:51:23 UTC Artifacts will be uploaded here
2025-10-28 13:52:44 UTC ya make is running...
🟡 2025-10-28 15:48:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15721 15293 0 161 249 18

🟢 2025-10-28 15:48:14 UTC Build successful.
🟢 2025-10-28 15:48:36 UTC ydbd size 3.8 GiB changed* by +352 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 83f6d8a merge: c6c1fec diff diff %
ydbd size 4 062 762 600 Bytes 4 062 762 952 Bytes +352 Bytes +0.000%
ydbd stripped size 1 509 476 504 Bytes 1 509 476 504 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

2025-10-28 14:04:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for c6c1fec has started.
2025-10-28 14:04:21 UTC Artifacts will be uploaded here
2025-10-28 14:05:48 UTC ya make is running...
🟡 2025-10-28 15:46:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39291 36451 0 7 2794 39

2025-10-28 15:46:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-28 16:07:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
747 (only retried tests) 724 0 1 0 22

2025-10-28 16:07:16 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-10-28 16:23:37 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
430 (only retried tests) 409 0 1 0 20

🟢 2025-10-28 16:23:43 UTC Build successful.
🟢 2025-10-28 16:24:03 UTC ydbd size 2.3 GiB changed* by +3.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 83f6d8a merge: c6c1fec diff diff %
ydbd size 2 427 340 768 Bytes 2 427 344 456 Bytes +3.6 KiB +0.000%
ydbd stripped size 517 566 728 Bytes 517 570 824 Bytes +4.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru added the rebase-and-check Rebase PR with the current base branch and check label Oct 29, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 29, 2025
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

2025-10-29 13:51:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 392653c has started.
2025-10-29 13:52:09 UTC Artifacts will be uploaded here
2025-10-29 13:53:32 UTC ya make is running...
🟡 2025-10-29 15:33:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39308 36490 0 5 2791 22

2025-10-29 15:33:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-29 15:58:24 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
448 (only retried tests) 430 0 0 0 18

🟢 2025-10-29 15:58:26 UTC Build successful.
🟢 2025-10-29 15:58:41 UTC ydbd size 2.3 GiB changed* by -400 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: dfa9bb6 merge: 392653c diff diff %
ydbd size 2 427 879 840 Bytes 2 427 879 440 Bytes -400 Bytes -0.000%
ydbd stripped size 517 665 576 Bytes 517 665 576 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

2025-10-29 13:52:29 UTC Pre-commit check linux-x86_64-release-asan for 392653c has started.
2025-10-29 13:52:47 UTC Artifacts will be uploaded here
2025-10-29 13:54:13 UTC ya make is running...
🟡 2025-10-29 16:05:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15738 15291 0 179 245 23

🟢 2025-10-29 16:05:32 UTC Build successful.
🟡 2025-10-29 16:05:54 UTC ydbd size 3.8 GiB changed* by +137.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9ccc99d merge: 392653c diff diff %
ydbd size 4 063 664 936 Bytes 4 063 806 008 Bytes +137.8 KiB +0.003%
ydbd stripped size 1 509 804 440 Bytes 1 509 860 568 Bytes +54.8 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru force-pushed the distconf/fix-quorums branch from cb9b63a to 4158cea Compare October 30, 2025 05:04
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

2025-10-30 05:08:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 490af38 has started.
2025-10-30 05:09:07 UTC Artifacts will be uploaded here
2025-10-30 05:10:38 UTC ya make is running...
2025-10-30 05:50:34 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

2025-10-30 05:08:23 UTC Pre-commit check linux-x86_64-release-asan for 490af38 has started.
2025-10-30 05:09:02 UTC Artifacts will be uploaded here
2025-10-30 05:10:28 UTC ya make is running...
2025-10-30 05:50:32 UTC Check cancelled

@alexvru alexvru force-pushed the distconf/fix-quorums branch from 4158cea to 502dabf Compare October 30, 2025 05:50
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

2025-10-30 05:52:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for c8e3ed6 has started.
2025-10-30 05:54:48 UTC Artifacts will be uploaded here
2025-10-30 05:57:12 UTC ya make is running...
🟢 2025-10-30 07:27:35 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39313 36487 0 0 2793 33

🟢 2025-10-30 07:27:48 UTC Build successful.
🟢 2025-10-30 07:28:03 UTC ydbd size 2.3 GiB changed* by -408 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: fc69c51 merge: c8e3ed6 diff diff %
ydbd size 2 428 004 736 Bytes 2 428 004 328 Bytes -408 Bytes -0.000%
ydbd stripped size 517 690 088 Bytes 517 690 088 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

2025-10-30 05:54:35 UTC Pre-commit check linux-x86_64-release-asan for c8e3ed6 has started.
2025-10-30 05:54:52 UTC Artifacts will be uploaded here
2025-10-30 05:56:16 UTC ya make is running...
🟡 2025-10-30 07:54:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15742 15315 0 164 240 23

🟢 2025-10-30 07:54:14 UTC Build successful.
🟢 2025-10-30 07:54:40 UTC ydbd size 3.8 GiB changed* by +416 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: fc69c51 merge: c8e3ed6 diff diff %
ydbd size 4 064 020 512 Bytes 4 064 020 928 Bytes +416 Bytes +0.000%
ydbd stripped size 1 509 934 072 Bytes 1 509 934 136 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) October 30, 2025 08:56
Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пофиксить опечатку

@alexvru alexvru force-pushed the distconf/fix-quorums branch from 502dabf to 7afe21c Compare October 30, 2025 10:02
Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

2025-10-30 10:04:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 45a7bb5 has started.
2025-10-30 10:04:21 UTC Artifacts will be uploaded here
2025-10-30 10:05:43 UTC ya make is running...
🟡 2025-10-30 11:30:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39315 36496 0 3 2791 25

2025-10-30 11:31:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-30 11:47:53 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
604 (only retried tests) 577 0 0 6 21

🟢 2025-10-30 11:47:56 UTC Build successful.
🟡 2025-10-30 11:48:13 UTC ydbd size 2.3 GiB changed* by +169.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d07fb05 merge: 45a7bb5 diff diff %
ydbd size 2 428 011 392 Bytes 2 428 184 840 Bytes +169.4 KiB +0.007%
ydbd stripped size 517 691 496 Bytes 517 709 800 Bytes +17.9 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

2025-10-30 10:04:34 UTC Pre-commit check linux-x86_64-release-asan for 45a7bb5 has started.
2025-10-30 10:04:50 UTC Artifacts will be uploaded here
2025-10-30 10:06:14 UTC ya make is running...
🟡 2025-10-30 12:06:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15742 15247 0 204 265 26

🟢 2025-10-30 12:06:30 UTC Build successful.
🟢 2025-10-30 12:06:53 UTC ydbd size 3.8 GiB changed* by +416 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: a5229a5 merge: 45a7bb5 diff diff %
ydbd size 4 064 343 880 Bytes 4 064 344 296 Bytes +416 Bytes +0.000%
ydbd stripped size 1 510 038 136 Bytes 1 510 038 200 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit 5bc9ae4 into ydb-platform:main Oct 30, 2025
11 checks passed
@alexvru alexvru deleted the distconf/fix-quorums branch October 30, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants