Skip to content

bug/setup-base-art: larger 2P setup art in portrait; whole cards on Twin Suns setup tiles - #947

Merged
yetanotheridentifier merged 1 commit into
mainfrom
bug/setup-base-art
Oct 28, 2026
Merged

yetanotheridentifier merged 1 commit into
mainfrom
bug/setup-base-art

Conversation

@yetanotheridentifier

Copy link
Copy Markdown
Owner

What changed

  • 2P setup, portrait: each base panel puts its art beside the name, set and HP, and Change base. The art takes the panel's full height, and the details sit in a 40% column on the right, where the name can take two lines. Before, a row of its own under the art cost the art its height. Landscape and 1 player are unchanged. stackActions is gone: it had become the same as twoPlayers.
  • Twin Suns setup tiles: each tile shows its label, the whole card fitted with object-fit: contain, then the name, on the plain surface. Before, the card was a cropped, darkened background, and its title bar and rules text showed behind the label and name.
  • docs/architecture-implementation.md describes both layouts.

Evidence

  • Three new tests in swuSetupScreen.test.tsx: the side-by-side layout in 2P portrait, the stacked layout in landscape and with 1 player, and the Twin Suns tile's fitted card between label and name with no background art. All failed before the change.
  • PWA suite: 1,715 passing. tsc -b and lint are clean.
  • Checked by hand on the iPhone (installed PWA) in portrait and landscape.

Left out

  • Full-width art (bug/2p-setup-base-images: base images small on 2P setup #930): at 390×844 each 2P card has about 195pt of height, and full-width art needs about 240pt, so the art takes the full height instead. By my estimate from the screenshot that is about 180pt wide, against about 124pt before.
  • Screenshots: the 390×844 and 844×390 screenshots are not attached. The headless browser cannot run in this environment, and the check on the phone took their place.

Closes #930
Closes #934

…ts name and Change base so it takes the card's full height; Twin Suns setup tiles show the whole card fitted between label and name instead of a cropped card behind them; tests pin both
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Preview: deleted, as this pull request is closed.

@yetanotheridentifier
yetanotheridentifier merged commit a9a5f2b into main Oct 28, 2026
7 checks passed
@yetanotheridentifier
yetanotheridentifier deleted the bug/setup-base-art branch October 28, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug/twin-suns-setup-art: card art sizing on Twin Suns setup bug/2p-setup-base-images: base images small on 2P setup

1 participant