Repository navigation
bug/setup-base-art: larger 2P setup art in portrait; whole cards on Twin Suns setup tiles - #947
Merged
Merged
Conversation
…ts name and Change base so it takes the card's full height; Twin Suns setup tiles show the whole card fitted between label and name instead of a cropped card behind them; tests pin both
|
Preview: deleted, as this pull request is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
stackActionsis gone: it had become the same astwoPlayers.object-fit: contain, then the name, on the plain surface. Before, the card was a cropped, darkened background, and its title bar and rules text showed behind the label and name.docs/architecture-implementation.mddescribes both layouts.Evidence
swuSetupScreen.test.tsx: the side-by-side layout in 2P portrait, the stacked layout in landscape and with 1 player, and the Twin Suns tile's fitted card between label and name with no background art. All failed before the change.tsc -band lint are clean.Left out
Closes #930
Closes #934