Dashboard skeleton #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, looks good so far! |
Graphql init
Add subscription for stats.uptime Complete functional implementation for the dashboard UI
kaffein
force-pushed
the
dashboard-skeleton
branch
from
a7c5c14
to
91da706
Compare
|
Can you PTAL @devth :) especially the CSS part haha thanks in advance |
Since we are using leiningen to manage dependencies, we have to make sure to include/align the versions of the dependencies with those pulled by shadow-cljs, especially those involving closure-compiler. Instead, if we opt to use shadow-cljs at some point, all the issues related to dependencies is solved by the tool and we would not have to deal with those as explained here by Thomas Heller : https://clojurians-log.clojureverse.org/shadow-cljs/2020-01-06
Since our main build tool is leiningen, we added a few aliases to allow it to interact with shadow-cljs. * lein watch : starts a new shadow-cljs watch process * lein compile : simply compiles the project * lein release : compiles the project for a production (minified js for each module) * lein cljs-repl : starts a clojurescript repl within the context of the app
Some new instructions were added regarding the use of leiningen as an entrypoint for managing shadow-cljs and the whole front-end building process
devth
approved these changes
Oct 27, 2020
Since lein-shadow plugin now generates shadow-cljs.edn from the configuration entry in project.clj, this file is not needed anymore
To ease development, leiningen has been removed. Shadow-cljs provides a very efficient and lightweight way during development. Leiningen will eventually be added (if needed) at the end to comply with the other Yetibot projects which already use it.
kaffein
force-pushed
the
dashboard-skeleton
branch
from
7e9ed6b
to
33cd60b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the overall structure and skeleton of the UI.
This is still a WIP but I would like to have it here as a draft PR so that you guys can follow up. Again do not hesitate to make suggestions on how we can improve it.