Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify benchmark comparison between yew master and changed project #14

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

bakape
Copy link

@bakape bakape commented May 23, 2021

No description provided.

wasm-bindgen = "0.2.62"

# UPDATE TO USE YOUR BRANCH
yew = { git = "https://github.com/yewstack/yew", branch = "master" }
yew = {path = "/home/janis/src/yew/packages/yew"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this path changed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally committed some dirty state. The benchmark script creates some as it runs.

@voidpumpkin
Copy link
Member

@bakape Please dont update this PR for the time being, i will be rebasing on top of upstream master and will cause a lot of changes in the process probably.
After thats done we can pick out stuff out of this PR that still suites us in that future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants