Repository navigation
Budget binding collections and enable shared growth checks (#677) - #698
Merged
Merged
Conversation
4 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #677.
The Python binding previously bypassed the shared collection lint. Cached character columns, Type 3 lookup results, nested savepoints, tagged Python values, and signature-field worklists could grow without charging the operation's memory budget. This change enables the shared lint and charges those allocations before growth; refusal raises
LimitErrorwith codememory_sizeand failed edits remain recoverable.Existing fixed keys, fixed geometry/schema sizes, pixel caps, budgeted reservations, and bounded copies state their bounds with focused lint expectations. Commits separate the audited modules; the character-column constructor and its two text-binding callers are kept together. The TIFF palette copy is fallible. The separate public limit for encoded Pixmap input is tracked in #697.
Acceptance:
cargo clippy --workspace --all-targets --all-features --locked -- -D warningspasses with the binding included.evidence/binding-collection-budgets/.Validation: locked extension build, Ruff, formatting, ty, workspace Clippy, and workspace Rust tests passed. The full Python suite passed 7,243 tests with 692 skipped; the targeted regression run passed 131 tests with 1 skipped. All six current-head CI checks passed: Rust, Python 3.11, Python 3.15, Python 3.15t, Audit, and Windows save. There are no unresolved review threads. No owner decision or release gate applies.