Repository navigation
Raise LimitError when a clipped page exceeds the precision bound - #735
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #728
A clipped render whose transformed page exceeds 524,288 pixels on either side now raises
pyropdf.LimitErrorwith codeclip_page_side. The diagnostic includes the transformed dimensions and the pixel limit. The renderer reads the existing bound from the limit registry. The API reference and rendering guides document the exception.Acceptance
LimitErrorwith the expected code.Verification
python3 tools/check.py --locked pythonandpython3 tools/check.py --locked rustpassed on macOS arm64. Python had 8,161 passed and 8 skipped.tools/generate_limits.py --checkandtools/api_reference.py --checkalso passed.