Skip to content

Commit

Permalink
Merge pull request #9 from yhkaplan/various-fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
yhkaplan authored Aug 4, 2020
2 parents f89eaf6 + 4167088 commit 343e8c9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ jobs:
asset_content_type: application/zip
asset_name: time.framework.zip
asset_path: ./time.framework.zip
uplad_url: '${{ steps.create_release.outputs.upload_url }}'
upload_url: '${{ steps.create_release.outputs.upload_url }}'
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# 💳 CreditCardScanner

CreditCardScanner is a library for taking a photo and scanning credit cards to make adding credit card details to user account more easy. It uses Apple's Vision API for **secure, on-device machine learning** to read following info from a credit card: number, name, and date.
CreditCardScanner is a library for scanning credit cards to make adding payment information to user accounts easy. It uses Apple's Vision API for **secure, on-device machine learning** to read the following info from a credit card: number, name, and expiration date.

![Example of CreditCardScanner running](example.gif)

## Installing

### Requirements

- iOS 13.0+ (due to Vision APIs first appearing in iOS 13.0)
- iOS 13.0+ (due to Vision API having first appeared in iOS 13.0)
- Even if your minimum deployment target is iOS 12 or lower, you can make this an iOS 13.0+ only feature using `canImport` and `@available`

```swift
Expand Down Expand Up @@ -41,8 +41,8 @@ extension ViewController: CreditCardScannerViewControllerDelegate {

- Add this to Cartfile: `github "yhkaplan/credit-card-scanner"`
- Follow instructions on [Carthage README](https://github.com/Carthage/Carthage#if-youre-building-for-ios-tvos-or-watchos) for integration **without adding to copy files script**
- This framework is build as a static one for Carthage, that's why it has the settings above
- To build with Carthage yourself, run `swift package generate-xcodeproj` then run
- This framework is build as a static framework for Carthage, that's why it has the settings above
- To build with Carthage yourself, run `swift package generate-xcodeproj` then run the necessary Carthage commands

### Cocoapods

Expand Down

0 comments on commit 343e8c9

Please sign in to comment.