feat: add user name to skyline model #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihong0618
reviewed
Jul 1, 2021
|
我觉得这块只支持英文和字母没问题，因为不同字体，中文长度不一样，不太好判断，后期也。 |
|
感谢~ |
|
@MamaShip 支持了中文字体 |
yihong0618
added a commit
that referenced
this pull request
Apr 20, 2023
feat: add user name to skyline model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
暂时只支持由英文和数字组成的名字。测试过是 sdf 在生成模型时对 Unicode 支持有问题，先给他们提了 issue：fogleman/sdf#25
close #21