-
-
Notifications
You must be signed in to change notification settings - Fork 878
Fix #2232: Trace chunk location in progress bar #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you okay with making this feature optional? e.g., show the line numbers only when options(knitr.progress.linenums = TRUE)
. Thanks!
Sure, I guess you would like the default to be |
Right ( |
Hi :-)
Feel free to tell me if there is any other suggestion. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thank you!
On #2232 we discussed a minor inconsistency in chunk names between RStudio and knitr. @yihui suggested to change the progress bar when knitting, so it shows the chunk name and the line number.
Here I do that and I add as well the file name, so we know precisely the location of the chunk even when having child documents. This is how the progress bar now looks with this pull request. Notice that the label in the progress bar includes
chunk name @ file name : line -range
.Download if you like the parent and child Rmd used to create the screenshot: test-rmd-with-child.zip
:
) to separate file name from the line number when reporting errors, I thought that would be a good design pattern to copy.