Skip to content

Conversation

samdark
Copy link
Member

@samdark samdark commented Aug 30, 2025

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #396

@samdark samdark requested a review from vjik August 30, 2025 10:45
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.08%. Comparing base (97fbe8b) to head (7285428).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #401   +/-   ##
=========================================
  Coverage     78.08%   78.08%           
  Complexity       28       28           
=========================================
  Files            11       11           
  Lines           178      178           
=========================================
  Hits            139      139           
  Misses           39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samdark samdark changed the title Fix #396: Do not run targets from args of make commands Fix #396: Prevent build to be triggered by codecept build or yii build Aug 30, 2025
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is partial solution. Problem actual for all goals in Makefile.

What do you think about solution with declaring only primary goal: #402 ?

@vjik
Copy link
Member

vjik commented Sep 1, 2025

Closed in favor #402

@vjik vjik closed this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants