Skip to content

Adapt to db changes #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Adapt to db changes #386

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8905c71
Adapt to db changes
rustamwin Aug 20, 2025
66ff649
Merge branch 'master' into fix-94
rustamwin Aug 21, 2025
9d93c01
Merge remote-tracking branch 'origin/master' into fix-94
rustamwin Aug 27, 2025
7ee4da1
Merge branch 'master' into fix-94
rustamwin Sep 3, 2025
310af01
Add changelog
rustamwin Sep 7, 2025
2f23b84
Bring back $params argument
rustamwin Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/CommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use Yiisoft\Db\Exception\Exception;
use Yiisoft\Db\Exception\InvalidConfigException;
use Yiisoft\Db\Exception\NotSupportedException;
use Yiisoft\Db\Expression\ExpressionInterface;
use Yiisoft\Db\Sqlite\Tests\Support\TestTrait;
use Yiisoft\Db\Tests\Common\CommonCommandTest;

Expand Down Expand Up @@ -468,12 +469,12 @@ public function testTruncateTable(): void
public function testUpdate(
string $table,
array $columns,
array|string $conditions,
array $params,
array|ExpressionInterface|string $conditions,
array|ExpressionInterface|string|null $from,
array $expectedValues,
int $expectedCount,
): void {
parent::testUpdate($table, $columns, $conditions, $params, $expectedValues, $expectedCount);
parent::testUpdate($table, $columns, $conditions, $from, $expectedValues, $expectedCount);
}

/**
Expand Down
5 changes: 3 additions & 2 deletions tests/QueryBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,12 +601,13 @@ public function testTruncateTable(): void
public function testUpdate(
string $table,
array $columns,
array|string $condition,
array|ExpressionInterface|string $condition,
array|ExpressionInterface|string|null $from,
array $params,
string $expectedSql,
array $expectedParams = [],
): void {
parent::testUpdate($table, $columns, $condition, $params, $expectedSql, $expectedParams);
parent::testUpdate($table, $columns, $condition, $from, $params, $expectedSql, $expectedParams);
}

#[DataProviderExternal(QueryBuilderProvider::class, 'upsert')]
Expand Down
Loading