Skip to content

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Apr 17, 2024

  • Refactor DataReader class
  • Rename DataReader to PdoDataReader class
  • Refactor BatchQueryResult
  • Use DataReaderInterface as a result of method Query::each()

As a result ->rewind() can be called multiple times before iteration. It allows to get access to the first row before iteration.

Related PRs

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC? ✔️
Fixed issues #821, #716

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (22da3a5) to head (1441b31).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #822   +/-   ##
=========================================
  Coverage     99.24%   99.24%           
- Complexity     1550     1554    +4     
=========================================
  Files            98       98           
  Lines          3848     3852    +4     
=========================================
+ Hits           3819     3823    +4     
  Misses           29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tigrov Tigrov added the status:under development Someone is working on a pull request. label Apr 17, 2024
Tigrov and others added 6 commits January 27, 2025 23:09
# Conflicts:
#	src/Command/AbstractCommand.php
#	tests/Common/CommonCommandTest.php
# Conflicts:
#	src/Query/BatchQueryResultInterface.php
#	src/Query/Query.php
#	src/Query/QueryInterface.php
…ctor-data-readers

# Conflicts:
#	src/Query/BatchQueryResultInterface.php
#	src/Query/Query.php
#	src/Query/QueryInterface.php
@Tigrov Tigrov added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Apr 14, 2025
@Tigrov Tigrov requested a review from a team April 14, 2025 05:31
@Tigrov Tigrov requested review from samdark and vjik April 15, 2025 10:13
@Tigrov Tigrov merged commit 43abebf into master Apr 16, 2025
68 checks passed
@Tigrov Tigrov deleted the refactor-data-readers branch April 16, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants