Skip to content

Remove yiisoft/json from require-dev section of composer.json #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2025
Merged

Remove yiisoft/json from require-dev section of composer.json #938

merged 3 commits into from
Mar 14, 2025

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Mar 13, 2025 •
edited
Loading

This was referenced Mar 13, 2025
Merged
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (e3351d5) to head (06f1fa8).

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #938   +/-   ##
=========================================
  Coverage     99.23%   99.23%           
  Complexity     1538     1538           
=========================================
  Files            98       98           
  Lines          3806     3806           
=========================================
  Hits           3777     3777           
  Misses           29       29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tigrov Tigrov mentioned this pull request Mar 13, 2025
Merged
@Tigrov Tigrov added the status:code review The pull request needs review. label Mar 13, 2025
@Tigrov Tigrov requested a review from a team March 13, 2025 05:26
vjik
vjik requested changes Mar 13, 2025
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ext-json also

@Tigrov
Copy link
Member Author

Tigrov commented Mar 13, 2025

Remove ext-json also

ext-json is used by the db package

@vjik
Copy link
Member

vjik commented Mar 13, 2025

ext-json is used by the db package

As of PHP 8.0.0, the JSON extension is a core PHP extension, so it is always enabled.

@Tigrov Tigrov requested a review from vjik March 13, 2025 20:31
@Tigrov Tigrov merged commit b5a8f8a into master Mar 14, 2025
3 checks passed
@Tigrov Tigrov deleted the remove-ext-json branch March 14, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tigrov @vjik @samdark