Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url name in ActionColumn::class. #127

Merged
merged 5 commits into from
Aug 20, 2023
Merged

Fix url name in ActionColumn::class. #127

merged 5 commits into from
Aug 20, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Aug 19, 2023

PR Summary

  • Updated Psalm Configuration
    Added new attributes to improve code analysis and spot unused code.

  • Enhanced Base Pagination Setup
    If the current route name isn't defined, the url name is now set to an empty string.

  • Improved Action Column Functionality
    Added a new property and method for current route management. Now URL creation uses the current route name when the url name is undefined.

  • Improved Grid View Method Return Types and Implementations
    Updated guessColumns() and renderColumns() methods with more precise return types. Incorporated the current route in rendering columns.

  • Optimized Link Sorter URL Creation
    URL creation now utilizes the current route name when the url name is undefined.

  • Updated List View for More Accurate Rendering
    Improved the renderAfterItem() and renderBeforeItem() methods. Their return types now consider other possibilities, helping to prevent errors and ensuring accurate rendering.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (82674ce) 100.00% compared to head (f42f2ba) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #127   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       469       469           
===========================================
  Files             19        19           
  Lines           1550      1558    +8     
===========================================
+ Hits            1550      1558    +8     
Files Changed Coverage Δ
src/ListView.php 100.00% <ø> (ø)
src/BasePagination.php 100.00% <100.00%> (ø)
src/Column/ActionColumn.php 100.00% <100.00%> (ø)
src/GridView.php 100.00% <100.00%> (ø)
src/LinkSorter.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw changed the title Fix url name Fix url name in ActionColumn::class. Aug 19, 2023
@terabytesoftw terabytesoftw linked an issue Aug 19, 2023 that may be closed by this pull request
@terabytesoftw terabytesoftw merged commit 9d44f77 into master Aug 20, 2023
20 checks passed
@terabytesoftw terabytesoftw deleted the fix-url-name branch August 20, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GridView override ActionColumn urlName parameter
2 participants