Update Quick Start instructions #222 #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukos
commented
May 26, 2018
lukos
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues | #222 |
This reverts commit f4e89fb.
Make use of AuthHandler clearer yiisoft#222
samdark
reviewed
Jun 1, 2018
| @@ -61,8 +78,8 @@ class AuthHandler | |||
| { | |||
| $attributes = $this->client->getUserAttributes(); | |||
| $email = ArrayHelper::getValue($attributes, 'email'); | |||
| $id = ArrayHelper::getValue($attributes, 'id'); | |||
There was a problem hiding this comment.
I'd show a situation where you want to handle both.
There was a problem hiding this comment.
You mean both id and subject?
There was a problem hiding this comment.
OpenID and GitHub (id and login).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.