Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise min PHP version to PHP 7.3, check compatibility PHP 8.3. #96

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Oct 5, 2023

PR Summary

  • Updated Formatting Rule for YAML Files
    The team has enhanced the rules that dictate how YAML files are formatted to improve code readability and consistency.

  • Improved Workflow Activation Conditions
    Changes have been made to the build.yml workflow. It now only activates upon certain key events (push and pull requests). There's also additional settings that direct it to ignore specific paths.

  • Revised Package Dependencies
    The composer.json file, which manages package dependencies, has been revised. It now insists on an updated version of phpunit/phpunit (version "^9.6"). Additionally, the requirements listed within the file have been reordered for better clarity.

  • Optimized PHPUnit Configuration
    The team upgraded the phpunit.xml.dist file with new coverage configuration. The method of performing regex assertions has also been modernized for performance and maintainability.

  • Upgraded Unit Test Methods
    The DatePickerTest.php and SelectableTest.php unit tests have been tweaked. Deprecated methods have been replaced with their modern counterparts for enhanced efficiency and compatibility.

  • Enhanced Compatibility for Test Files
    Finally, modifications were made to the TestCase.php and bootstrap.php files. These changes were required to render them compatible with PHPUnit 6.x. This modification results in elimination of the compatibility.php file altogether.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant