Fix PHPStan errors #20523

max-s-lab · 2025-09-13T10:04:53Z

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues

max-s-lab · 2025-09-13T10:07:19Z

framework/web/Controller.php

    public function renderAjax($view, $params = [])
    {
-        return $this->getView()->renderAjax($view, $params, $this);
+        return $this->view->renderAjax($view, $params, $this);


As far as I know, $this->view is completely identical to $this->getView(), so nothing should break

Is it? 1. There's initialization happens. 2. One may extend and override the method.

You're right. I fixed it using annotations

max-s-lab · 2025-09-13T10:07:47Z

framework/validators/InlineValidator.php

            $method = [$model, $method];
        } elseif ($method instanceof \Closure) {
-            $method = $this->method->bindTo($model);
+            $method = $method->bindTo($model);


framework/requirements/YiiRequirementChecker.php

codecov · 2025-09-13T10:08:20Z

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.07%. Comparing base (04202f0) to head (e75e434).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
framework/web/Controller.php	0.00%	2 Missing ⚠️
framework/validators/InlineValidator.php	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (04202f0) and HEAD (e75e434). Click for more details.

HEAD has 19 uploads less than BASE

Flag BASE (04202f0) HEAD (e75e434)

21 2

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #20523       +/-   ##
=============================================
- Coverage     64.49%   21.07%   -43.42%     
+ Complexity    11574    11473      -101     
=============================================
  Files           433      433               
  Lines         37605    37519       -86     
=============================================
- Hits          24253     7907    -16346     
- Misses        13352    29612    +16260

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

max-s-lab · 2025-09-13T10:10:51Z

framework/di/Container.php

                    }
                } else {
-                    $isClass = $class !== null && !$class->isBuiltin();
+                    $isClass = $class instanceof \ReflectionNamedType && !$class->isBuiltin();


This code is executed for PHP8.0 and above, so isBuiltin is only available in ReflectionNamedType. Nothing should break

Can you achieve the same with some annotations instead? Adding more checks, which aren't useful, to DI container costs performance.

max-s-lab · 2025-09-13T10:11:11Z

build/controllers/ReleaseController.php


        $this->stdout('updating mimetype magic file and mime aliases...', Console::BOLD);
-        $this->dryRun || Yii::$app->runAction('mime-type', ["$frameworkPath/helpers/mimeTypes.php"], ["$frameworkPath/helpers/mimeAliases.php"]);
+        $this->dryRun || Yii::$app->runAction('mime-type', ["$frameworkPath/helpers/mimeTypes.php"]);


Are you sure it works after the change?

Yes, I checked it out.

max-s-lab · 2025-09-13T10:11:40Z

build/controllers/views/translation/report_html.php

+ *
+ * @phpstan-var \yii\web\View&object{
+ *     context: \yii\build\controllers\TranslationController,
+ * } $this


samdark · 2025-09-15T17:51:25Z

build/controllers/ReleaseController.php


        $this->stdout('updating mimetype magic file and mime aliases...', Console::BOLD);
-        $this->dryRun || Yii::$app->runAction('mime-type', ["$frameworkPath/helpers/mimeTypes.php"], ["$frameworkPath/helpers/mimeAliases.php"]);
+        $this->dryRun || Yii::$app->runAction('mime-type', ["$frameworkPath/helpers/mimeTypes.php"]);


Are you sure it works after the change?

samdark · 2025-09-15T17:52:51Z

framework/di/Container.php

                    }
                } else {
-                    $isClass = $class !== null && !$class->isBuiltin();
+                    $isClass = $class instanceof \ReflectionNamedType && !$class->isBuiltin();


Can you achieve the same with some annotations instead? Adding more checks, which aren't useful, to DI container costs performance.

samdark · 2025-09-15T17:56:30Z

framework/web/Controller.php

    public function renderAjax($view, $params = [])
    {
-        return $this->getView()->renderAjax($view, $params, $this);
+        return $this->view->renderAjax($view, $params, $this);


Is it? 1. There's initialization happens. 2. One may extend and override the method.

max-s-lab and others added 2 commits September 13, 2025 14:03

Fix PHPStan errors

5edb715

Merge branch 'master' into phpstan-level-2-2

865a4d6

max-s-lab commented Sep 13, 2025

View reviewed changes

framework/requirements/YiiRequirementChecker.php Show resolved Hide resolved

max-s-lab commented Sep 13, 2025

View reviewed changes

max-s-lab marked this pull request as ready for review September 13, 2025 10:17

samdark requested changes Sep 15, 2025

View reviewed changes

max-s-lab and others added 2 commits September 15, 2025 22:58

cr fix

e643447

Merge branch 'master' into phpstan-level-2-2

e75e434

max-s-lab requested a review from samdark September 15, 2025 19:25

samdark approved these changes Sep 15, 2025

View reviewed changes

samdark merged commit 53bdfc3 into yiisoft:master Sep 15, 2025
25 of 96 checks passed

Uh oh!

Fix PHPStan errors #20523

Fix PHPStan errors #20523

Uh oh!

Conversation

max-s-lab commented Sep 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

max-s-lab Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

max-s-lab Sep 15, 2025 •

edited

Loading

codecov bot commented Sep 13, 2025 •

edited

Loading