Skip to content

Fix PHPStan/Psalm annotations in Yii::createObject #20524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2025
Merged

Fix PHPStan/Psalm annotations in Yii::createObject #20524

merged 4 commits into from
Sep 15, 2025
+3 −2

Conversation

max-s-lab
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues

@max-s-lab max-s-lab marked this pull request as draft September 13, 2025 10:33
@codecov Codecov
Copy link

codecov bot commented Sep 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.49%. Comparing base (398dea3) to head (5b63bf9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #20524   +/-   ##
=========================================
  Coverage     64.49%   64.49%           
  Complexity    11574    11574           
=========================================
  Files           433      433           
  Lines         37605    37605           
=========================================
  Hits          24253    24253           
  Misses        13352    13352

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-s-lab max-s-lab marked this pull request as ready for review September 13, 2025 10:53
Arhell
Arhell reviewed Sep 14, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samdark samdark merged commit 68600db into yiisoft:master Sep 15, 2025
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Arhell Arhell Arhell left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-s-lab @Arhell @samdark