Skip to content

Conversation

@terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

sebastianbergmann/phpunit#5063

Copilot AI review requested due to automatic review settings October 28, 2025 10:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors PHPUnit test files to replace the deprecated withConsecutive method with a willReturnCallback approach using invocation matchers, addressing PHPUnit's deprecation notice (issue #5063).

Key Changes:

  • Replaced withConsecutive() with willReturnCallback() and manual invocation count checking
  • Added invocation count matchers ($this->exactly(n)) to track method call sequences
  • Updated class references to use ::class syntax instead of string literals

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/framework/log/TargetTest.php Refactored two test methods to use callback-based assertion pattern instead of withConsecutive
tests/framework/log/SyslogTargetTest.php Converted 7 consecutive syslog method expectations to callback-based validation
tests/framework/log/DispatcherTest.php Updated dispatcher test to use callback pattern with improved string comparison (str_starts_with)
tests/framework/BaseYiiTest.php Migrated 6 consecutive logger method expectations to use invocation matcher callbacks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 09:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 13 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 09:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 09:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@terabytesoftw terabytesoftw merged commit 1821a61 into yiisoft:master Oct 31, 2025
75 checks passed
@terabytesoftw terabytesoftw deleted the fix-test-5 branch October 31, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants