Skip to content

Conversation

@yinghu5
Copy link
Owner

@yinghu5 yinghu5 commented Apr 29, 2019

Working with @yajiedesign, @TaoLv @pengzhao-intel @larroy @NeoZhangJiangyu to restructure the mxnet cmake build systems to make MKLDNN, MKL logic correct.
In the past, the logic to set BLAS in ChooseBLAS.cmake is incorrect. Now, unlock the MKL and MKLDNN, USE_BLAS have high priority than other.

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Working with @yajiedesign, @TaoLv @pengzhao-intel @larroy @NeoZhangJiangyu to restructure the mxnet cmake build systems to make MKLDNN, MKL logic correct. 
In the past,  the logic to set  BLAS in ChooseBLAS.cmake is incorrect.  Now, unlock the MKL and MKLDNN,   USE_BLAS have high priority than other.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants