fix: tags & single chapter dl

yinyanfr · Mar 18, 2023 · f14cce3 · f14cce3
1 parent 471c3e7
commit f14cce3
Show file tree

Hide file tree

Showing 10 changed files with 32 additions and 27 deletions.
diff --git a/.npmignore b/.npmignore
@@ -1,3 +1,4 @@
 node_modules/
 .DS_Store
-tmp/
+tmp/
+asset/
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,16 +1,25 @@
 # Changelog
 
-# 1.5.0
+## 1.5.1
+
+`2023-03-18`
+
+### Fix
+
+- [CLI] Fixed the error when using `--chapters` with one single index
+- [Library] Fixed the bug where tags are not added to ComicInfo.xml
+
+## 1.5.0
 
 `2023-03-18`
 
 ### Features
 
 - You can now download or embbed a ComicInfo.xml in chapters
   - `getSerieInfo` and `list`(CLI) now displays ComicInfo fields
-  - [Library] added `info` (boolean) as an option for serie, you can also pass it to chapter download, but you need to provide the info object
+  - [Library] Added `info` (boolean) as an option for serie, you can also pass it to chapter download, but you need to provide the info object
   - [Library] Added options for list so that you can generate and write ComicInfo.xml
-  - [CLI] added `-i, --info` flag for `dl` to write ComicInfo.xml and for `ls` to display it, use `-o` for `ls` to write the ComicInfo.xml
+  - [CLI] Added `-i, --info` flag for `download` to write ComicInfo.xml and for `list` to display it, use `-o` for `ls` to write the ComicInfo.xml
 
 ### Fix
 

diff --git a/README.md b/README.md
@@ -16,6 +16,16 @@ This library is not for browsers.
 - Downloading progress watch
 - Generates [ComicInfo.xml](https://anansi-project.github.io/docs/comicinfo/intro)
 
+## :framed_picture: Gallery
+
+### List of chapters
+
+![List of chapters](asset/ls.png)
+
+### Downloading
+
+![Downloading](asset/dl.png)
+
 ## :green_book: Quick Start
 
 You need Node.js (LTS or the current version) to run this project.

diff --git a/asset/dl.png b/asset/dl.png
diff --git a/asset/ls.png b/asset/ls.png
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "zerobyw-dl",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "Yet another batch downloader for zerobyw",
   "main": "dist/index.js",
   "bin": "dist/cli.js",
@@ -30,15 +30,13 @@
     "@types/args": "^5.0.0",
     "@types/jsdom": "^21.1.0",
     "@types/node": "^18.15.0",
-    "@types/xml": "^1.0.8",
     "typescript": "^4.9.5"
   },
   "dependencies": {
     "archiver": "^5.3.1",
     "args": "^5.0.3",
     "axios": "^1.3.4",
     "jsdom": "^21.1.1",
-    "xml": "^1.0.1",
     "yesno": "^0.4.0"
   }
 }
diff --git a/src/commands.ts b/src/commands.ts
@@ -92,7 +92,7 @@ export const downloadCommand: Command = async (name, sub, options = {}) => {
         retry,
         info,
         chapters: chapters
-          ? chapters.split(",").map((e) => parseInt(e))
+          ? `${chapters}`.split(",").map((e) => parseInt(e))
           : undefined,
       });
     } else {

diff --git a/src/global.d.ts b/src/global.d.ts
@@ -103,7 +103,7 @@ interface CliOptions {
   maxTitleLength: number; // max-title-length
   zipLevel: number; // zip-level
   retry: boolean;
-  chapters: string; // 1,2,4,7
+  chapters: string | number; // 1,2,4,7 as string or a single number
   info?: boolean;
 }
 

diff --git a/src/index.ts b/src/index.ts
@@ -121,6 +121,9 @@ export default class ZeroBywDownloader {
         }
       }
     });
+    if (tags.length) {
+      info.Tags = tags.join(",");
+    }
 
     const tagGroup2 = document.querySelectorAll<HTMLSpanElement>(
       Selectors.tags2