Merged
Conversation
This previously cause an underflow, and then an out-of-memory error. We could be more sophisticated than the approach below, but this is better than nothing.
vext01
reviewed
Dec 11, 2025
| // don't try hard. | ||
| print!("\r{lhs} {rhs}"); | ||
| } else { | ||
| // If the terminal is a bit too narrow, chop the LHS down and retain all of the RHS. |
Contributor
There was a problem hiding this comment.
I think this is actually chopping the rhs off? i.e. the oldest iteration times seem to be kept.
Contributor
Author
There was a problem hiding this comment.
It's chopping the RHS of the LHS. We could be more clever here, but it would be diminishing returns.
Contributor
There was a problem hiding this comment.
Ah, i see. Sorry, misunderstood the comment then.
This behaviour is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This previously cause an underflow, and then an out-of-memory error.
We could be more sophisticated than the approach below, but this is better than nothing.