Fix lulpeg benchmark arg handling for harness compatibility#39
Merged
Conversation
luagrammar.lua expects arg[1]=module path and arg[2]=source file when run standalone, but via the harness arg contains harness arguments (arg[1]="lulpeg", arg[2]="1"), causing it to load the benchmark object instead of the LuLPeg library. Fix by temporarily setting arg to the expected values before dofile().
Contributor
|
I can buy this. I'll tag @vext01 so he can look at this next week, but in the meantime I think this is worth merging. |
Contributor
Author
|
Without this fix I get: |
Contributor
|
FWIW I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
luagrammar.lua expects arg[1]=module path and arg[2]=source file when run standalone, but via the harness arg contains harness arguments (arg[1]="lulpeg", arg[2]="1"), causing it to load the benchmark object instead of the LuLPeg library.
Fix by temporarily setting arg to the expected values before dofile().