Convert a todo! to a FIXME in the trace optimiser.#1831
Merged
ltratt merged 1 commit intoykjit:masterfrom Aug 4, 2025
Merged
Conversation
ltratt
reviewed
Aug 4, 2025
| // Can we still hit this case? | ||
| todo!(); | ||
| // FIXME: implement the optimisation. | ||
| return op; |
Contributor
There was a problem hiding this comment.
I think you can delete the return op; line and the code will behave the same. If so, please force push an update.
This scenario can indeed happen. I've just seen it with the Lua tests with the "really long trace" fix that's pending to merge.
Contributor
Author
|
It's the same. Force pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This scenario can indeed happen. I've just seen it with the Lua tests with the "really long trace" fix that's pending to merge.
Required for ykjit/yklua#129