Add idempotent promote for i8 and sync ykllvm#2119
Merged
ltratt merged 1 commit intoykjit:masterfrom Mar 6, 2026
Merged
Conversation
Contributor
Author
|
Never seen that kind of error before. Hoping it's transient. Give it a kick? |
Contributor
|
Looks like the format check somehow failed and I don't know how to override it. Do you know how? If not, just force push to this branch and that should kick it. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Looks like rust nightly has changed something that's easy to fix. Please force push / add a commit as appropriate. |
Contributor
Author
|
Fixed. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
I've force pushed this to include stuff required to optimise bytecode dispatch in ykmicropython. |
ltratt
reviewed
Mar 6, 2026
ykrt/src/mt.rs
Outdated
| /// here means that something has gone wrong elsewhere. | ||
| pub(crate) fn promote_i8(&mut self, val: i8) -> bool { | ||
| if let MTThreadState::Tracing { promotions, .. } = self.peek_mut_tstate() { | ||
| promotions.push(val as u8); // `as` intended -- it's the bit pattern we want. |
Contributor
There was a problem hiding this comment.
cast_unsigned is preferred here (it's a newish API and is very nice!). Please force push.
This also pulls is the optsize serialiser change in ykllvm.
Contributor
Author
|
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs ykjit/ykllvm#316