Undo 32-bit idempotent return type hack.#105
Merged
ltratt merged 1 commit intoykjit:mainfrom Mar 19, 2025
Merged
Conversation
Contributor
Author
|
@ltratt do you think this one should go in too? Is it now trusted now that we think the problem was the ykllvm bug? |
Contributor
|
"Yes but":
|
Contributor
Author
|
OK. I'll hold off. I don't expect a large performance change, but let's see. If anything the removal of bitcast instructions should be in our favour. |
Contributor
|
Please merge in master and address the merge conflict. Because this one's quite subtle, I think a force push is not the way to go here. |
Contributor
Author
|
I think this is correct. The lua tests are passing. |
Contributor
|
Looks good! Please squash. |
Contributor
Author
|
squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires ykjit/yk#1651