Merged
Conversation
Contributor
|
This smells like a probable problem that Richards is highlighting and that we need to at least somewhat understand. |
Contributor
Author
|
After investigating a bit, I think the richards slowdown is unrelated to this change:
I don't see any obvious non-determinism in richards, so my vague guess is that the non-determinism comes from yk (timings and the such). I think we should merge this and then I can revert to the hot location debug work and see if it shines any light on what's going on with richards. Would you be ok with that? |
Before, we'd make a location for *every* pc in an unmdumped function. This could lead to us tracing too much. This fixes this by using the same heuristics that we use for normal "parsed" functions to decide where loops start, and thus where to put yk locations. (Ideally we'd dump and undump the locations, thus retaining JIT state, but that could be tricky. One for another day) In terms of performance, most benchmarks either don't change, or speed up a little bit (in the order of 5%).
vext01
force-pushed
the
fix-undumped-locs
branch
from
7fad073 to
d8f1373
Compare
Contributor
Author
|
Force pushed commit message update and added a comment about one day making the locations survive a dump+undump. I think this is ready to merge if you are happy with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits.
Note that this comes with a caveat, explained in the second commit. Hence this is a draft.