You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suspect it's mainly because these ops are almost always followed by loading to the stack, which destroys all our optimisation information at the moment.
i should be a constant (since load_inst is elidable). I thinkra will be a constant folded value (but this needs checking). That probably means that GETARG_sBx is "destroying" const-ness. It might be that is inevitable, but it might mean that (a) we haven't adjusted yklua correctly (b) there's a missing optimisation in yk. I would guess that (a) is more likely. Working out what's going on might require running the C preprocessor to see how all the macros are expanded. But, ultimately, if we can avoid a new yk_promote that will both be faster and probably benefit other code than just LOADI/LOADK.
Just to be clear: this PR might be the right thing to do, but I hope there might be a better fix elsewhere that subsumes this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no significant results on benchmarks with jitc_yk:
I suspect it's mainly because these ops are almost always followed by loading to the stack, which destroys all our optimisation information at the moment.