[ASAP-740] - add reminders for discussions #4518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4518 +/- ##
========================================
Coverage 99.49% 99.50%
========================================
Files 1088 1090 +2
Lines 21947 22232 +285
Branches 6950 7073 +123
========================================
+ Hits 21836 22121 +285
Misses 111 111 ☔ View full report in Codecov by Sentry. |
gabiayako
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
We need to add item.entity !== 'Discussion' here as well https://github.com/yldio/asap-hub/blob/master/apps/crn-frontend/src/dashboard/Dashboard.tsx#L34:L36 so the reminders are behind a feature flag
| }; | ||
|
|
||
| test('the person who started the discussion should not see discussion started reminders', async () => { | ||
| const userId = 'user-who-created-manuscript'; |
There was a problem hiding this comment.
Suggested change
| const userId = 'user-who-created-manuscript'; | |
| const userId = 'user-who-started-discussion'; |
| ${'asap-staff-user'} | ${'ASAP Staff'} | ||
| ${'trainee-user'} | ${'Trainee'} | ||
| `( | ||
| 'the team member with role $role should not see manuscript created reminders', |
There was a problem hiding this comment.
Suggested change
| 'the team member with role $role should not see manuscript created reminders', | |
| 'the team member with role $role should not see the discussion ended reminders', |
Comment on lines
+423
to
+429
| repliesCollection(limit: 100) { | ||
| items { | ||
| sys { | ||
| id | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| repliesCollection(limit: 100) { | |
| items { | |
| sys { | |
| id | |
| } | |
| } | |
| } |
I believe we're not using this repliesCollection :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://asaphub.atlassian.net/browse/ASAP-740