-
Notifications
You must be signed in to change notification settings - Fork 18
Add 2kki locations: Map3151, 3158 #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1548,10 +1548,23 @@ | |
| ], | ||
| "3131": { "title": "Snow Black: Keyhole", "urlTitle": "Snow_Black#Keyhole" }, | ||
| "3136": "Red Black World", | ||
| "3151":[ | ||
| { "title": "Painted Landscape", "coords": { "x1": 0, "y1": 18, "x2": 59, "y2": 55 } }, | ||
| { "title": "Blue Undergrowth", "coords": { "x1": 41, "y1": 0, "x2": 59, "y2": 15 } }, | ||
| { "title": "Dazzling Garden", "coords": { "x1": 0, "y1": 0, "x2": 39, "y2": 15 } }, | ||
| { "title": "Waterworks", "coords": { "x1": 24, "y1": 76, "x2": 44, "y2": 89 } }, | ||
| { "title": "Red Desert Ruins", "coords": { "x1": 0, "y1": 72, "x2": 59, "y2": 74 } }, | ||
| { "title": "Red Desert Ruins", "coords": { "x1": 0, "y1": 76, "x2": 21, "y2": 89 } } | ||
| ], | ||
| "3154": [ | ||
| { "title": "Star Cubes World", "coords": { "x1": 0, "y1": 213, "x2": 99, "y2": 349 } }, | ||
| "Dazzling Garden" | ||
| ], | ||
| "3158": { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was using the previous map argument necessary here? It should only be used in Yume 2kki if there is no other option, as any possibility of warping while on the same map (e.g. use of the Bat effect) will prevent it from working properly.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Map3158 has 2 locations, "Cubic Cliffs" and "Painted Landscape", sharing the same map and coords, causing both to appear. (additionally, regarding this point, there are other instances of else used in this config, and those will also be affected)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That works in that case, as there is no other alternative and the map should not be affected post-fix ultimately. About the other else cases in the Yume 2kki configs, they are all tied to similar cases, either due to reusing the same coords (e.g. Jigsaw Puzzle World menu, Bleak Future boy balcony which uses the same coordinates than the normal Bleak Future balcony), or to avoid bugs (e.g. the Mask Shop map is set with this argument, as while in the Deluxe Mask Shop, when buying a mask, the game quickly teleports you to the Mask Shop, which leads to a display bug otherwise, and this setting allows avoiding this problem altogether).
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for the explanation. Thats very helpful and thanks for the review as well! |
||
| "3157": "Cubic Cliffs", | ||
| "3151": "Painted Landscape", | ||
| "else": "Painted Landscape" | ||
| }, | ||
| "3191": [ | ||
| { "title": "Ballerina Forest", "coords": { "x1": 10, "y1": 178, "x2": 10, "y2": 178 } }, | ||
| "Technicolor Towers" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's best to have one of the coordinates for a location to be set as an else, as-in, have it be displayed if the coordinates of the player is in none of those areas, like how it is done for all other coordinates set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. i will add it