Enhancing ocio config embedding of looks #25

jakubjezek001 · 2024-07-30T14:56:41Z

selenium downgrade
enhancing AYON ocio look operator
enhancing AYON ocio look operator testing
testing config file adding logging and stagig file fixture

TODO:

enhancing AYON hiero effect operator and testing:
- adding target path like in AYON ocio look operator (for AYON publishing workflow)
- testing wider coverage

…ion setting in start.ps1 - Updated selenium dependency to version 4.16.0 - Added pytest as a dev-dependency in poetry - Removed specific Poetry version setting from start.ps1

WIP on enhancement/renderer-basic - Added a list of search paths - Initialized variables and operators - Implemented methods to handle search paths - Updated file loading process with target path option

Adjusted test method to use kwargs and results dictionaries for better parameter handling, updated assertions accordingly.

…sor. Increased clarity and functionality in OCIO configuration handling.

- Updated method to clear operators - Modified typing import in a file

- Added logging functionality using Python's logging module - Changed the setting to keep test results after session ends

Changed the configuration to set KEEP_TEST_RESULTS to False in order to prevent keeping test results after each run.

…or object. - Refactored debug logs and variable names for clarity - Updated assertions to use the renamed 'processor' object

- Added new test parameter structure with file paths and expected results. - Adjusted test method to accept kwargs and results instead of just a path. - Updated processor initialization and debug log messages. - Modified assertions to compare processor attributes with expected results.

- Update target directory path handling and logging - Adjust file paths accordingly. - Add debug logs for new file paths and processor attributes. - Refactor test cases to match changes made in the main code.

tweak-wtf

just some notes here and there.
tbh... as long as the ci testing doesn't fail we're pretty safe to know we're not breaking other parts when merging. And they do run without any issues!

so you have my blessing :D

lablib/generators/ocio_config.py

lablib/processors/ayon_hiero_effect_file.py

pyproject.toml

- Added support for specifying a target view space in the OCIO Config file. - Refactored code to handle default target view space assignment. - Improved code formatting and removed redundant comments.

- Updated method to append search paths instead of clearing and appending. - Improved logic for handling multiple search path arguments.

…roughout the code for consistency. - Removed unnecessary _ocio_transforms list - Replaced instances of _ocio_transforms with _operators throughout the code for consistency

- Added import statement for PyOpenColorIO. - Updated test_OCIOConfigFileGenerator method to include additional tests related to environment variables, config file path, color command, config file content, environment variables in OCIO config, search paths with environment variables, context-related colorspace/look/view.

OCIO api is having bug which is not allowing adding search paths and environment variables via official methods. This way we are adding it via serialisation but it will need to be replaced in future with proper way.

iLLiCiTiT · 2024-09-11T09:25:24Z

lablib/generators/ocio_config.py

-                f"--ociolook:from=\"{self.working_space}\""
-                f":to=\"{self.working_space}\""
-            ),
+            (f'--ociolook:from="{self.working_space}"' f':to="{self.working_space}"'),


Suggested change

(f'--ociolook:from="{self.working_space}"' f':to="{self.working_space}"'),

f'--ociolook:from="{self.working_space}":to="{self.working_space}"',

tweak-wtf · 2024-09-11T16:57:41Z

chiming in real quick.
the only reason this is not already merged yet is that fd64571 introduced a bug.
the stacktrace is available here: https://github.com/ynput/LabLib/actions/runs/10387476368/job/28761036338?pr=25#step:9:37

seems like the only thing that's wrong is that $CONTEXT is not set in test environment. i think if we just pass this in the test case we're golden

jakubjezek001 added 10 commits July 26, 2024 16:38

Update dependencies in pyproject.toml and remove specific Poetry vers…

334c6c7

…ion setting in start.ps1 - Updated selenium dependency to version 4.16.0 - Added pytest as a dev-dependency in poetry - Removed specific Poetry version setting from start.ps1

WIP on enhancement/renderer-basic

c6e0c47

WIP on enhancement/renderer-basic - Added a list of search paths - Initialized variables and operators - Implemented methods to handle search paths - Updated file loading process with target path option

Refactor test for AYONOCIOLookFileProcessor parameters

c58aa3c

Adjusted test method to use kwargs and results dictionaries for better parameter handling, updated assertions accordingly.

Update OCIO search paths and add attributes to AYONOCIOLookFileProces…

ba9dd3a

…sor. Increased clarity and functionality in OCIO configuration handling.

Refactor OCIO configuration and typing in files

af0b7db

- Updated method to clear operators - Modified typing import in a file

Add logging and update test results directory handling

705692c

- Added logging functionality using Python's logging module - Changed the setting to keep test results after session ends

Update test configuration to not keep test results.

d75554b

Changed the configuration to set KEEP_TEST_RESULTS to False in order to prevent keeping test results after each run.

Refactor debug logs and variable names, update assertions for process…

b98f4f7

…or object. - Refactored debug logs and variable names for clarity - Updated assertions to use the renamed 'processor' object

WIP refactor ayon hiero effect file module

ce8525c

jakubjezek001 requested a review from tweak-wtf July 30, 2024 15:53

AYONHieroEffectsFileProcessor.

5ef5267

- Update target directory path handling and logging - Adjust file paths accordingly. - Add debug logs for new file paths and processor attributes. - Refactor test cases to match changes made in the main code.

tweak-wtf approved these changes Jul 31, 2024

View reviewed changes

jakubjezek001 added 3 commits August 8, 2024 14:16

Add target view space handling and refactor code for better readability.

4091f17

- Added support for specifying a target view space in the OCIO Config file. - Refactored code to handle default target view space assignment. - Improved code formatting and removed redundant comments.

Added a docstring to clarify the behavior of the load method.

86c05e8

Refactor search paths handling in OCIOConfigFileGenerator

32aac90

- Updated method to append search paths instead of clearing and appending. - Improved logic for handling multiple search path arguments.

jakubjezek001 force-pushed the slate-testing-and-selenium-downgrading branch from bd6892f to 0d91f37 Compare August 8, 2024 12:51

jakubjezek001 added 4 commits August 8, 2024 14:51

Remove unused _ocio_transforms list and replace it with _operators th…

0d91f37

…roughout the code for consistency. - Removed unnecessary _ocio_transforms list - Replaced instances of _ocio_transforms with _operators throughout the code for consistency

Solving the search path and environment adding inconsistency

fd64571

OCIO api is having bug which is not allowing adding search paths and environment variables via official methods. This way we are adding it via serialisation but it will need to be replaced in future with proper way.

cccid has to be set to 0 if none is set

42fe3b9

jakubjezek001 requested a review from iLLiCiTiT September 10, 2024 12:33

jakubjezek001 marked this pull request as ready for review September 10, 2024 12:33

jakubjezek001 removed the request for review from iLLiCiTiT September 10, 2024 12:34

iLLiCiTiT reviewed Sep 11, 2024

View reviewed changes

iLLiCiTiT approved these changes Sep 11, 2024

View reviewed changes

sets search paths and environment using native methods

5bd6f14

tweak-wtf merged commit 30f9f9f into develop Sep 14, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancing ocio config embedding of looks #25

Enhancing ocio config embedding of looks #25

jakubjezek001 commented Jul 30, 2024 •

edited

Loading

tweak-wtf left a comment

iLLiCiTiT Sep 11, 2024

tweak-wtf commented Sep 11, 2024

	(f'--ociolook:from="{self.working_space}"' f':to="{self.working_space}"'),
	f'--ociolook:from="{self.working_space}":to="{self.working_space}"',

Enhancing ocio config embedding of looks #25

Enhancing ocio config embedding of looks #25

Conversation

jakubjezek001 commented Jul 30, 2024 • edited Loading

TODO:

tweak-wtf left a comment

Choose a reason for hiding this comment

iLLiCiTiT Sep 11, 2024

Choose a reason for hiding this comment

tweak-wtf commented Sep 11, 2024

jakubjezek001 commented Jul 30, 2024 •

edited

Loading