Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher: Reset all attributes to default feature #153

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bradenjennings
Copy link
Contributor

Changelog Description

Add a button to publisher to reset all creator and publisher attributes.
https://app.clickup.com/t/6658547/AY-3429

Additional info

Paragraphs of text giving context of additional technical information or code examples.

Testing notes:

  1. start with this step
  2. follow this step

@ynbot ynbot added size/XS type: feature Adding something new and exciting to the product labels Mar 6, 2024
@bradenjennings
Copy link
Contributor Author

Here is an example image of "Reset attributes to default" button added
image

@bradenjennings bradenjennings changed the title feature/AY-3429_reset_attributes_to_default Publisher - Reset all attributes to default feature Mar 7, 2024
@bradenjennings bradenjennings changed the title Publisher - Reset all attributes to default feature Publisher: Reset all attributes to default feature Mar 7, 2024
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented May 22, 2024

I'm a little bit worried regarding this comment #146 (review) .

If there are attribute definitions that can't set "correct" default value for all instances, then this feature might cause huge issues. In case of maya review there is resolution width and height based on settings, both are filled during create, but attribute definitions have default set to 0.

I'm not sure how many other places use the same concept. If it would be only this place then we can probably live with it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: feature Adding something new and exciting to the product
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

3 participants