Refactor OCIO config handling, introduce fallback mechanism #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added function to extract config path from profile data - Updated global config retrieval to use new function - Introduced fallback mechanism for missing product entities
ynbot
added
type: enhancement
… in colorspace and conversion modules. - Update version references to 0.4.5 for future removal in colorspace module. - Update function name and version reference to 0.4.4 for imageio config conversion in the conversion module.
|
Could this get better testing notes - and maybe a slightly more description PR description as well. Why are these changes made and what does it now allow us to do that wasn't possible before or what does it fix? |
- Removed redundant folder info handling - Added fallback mechanism for missing folder info
…files-and-templated-values
iLLiCiTiT
reviewed
Aug 8, 2024
iLLiCiTiT
reviewed
Aug 8, 2024
Improve handling of fallback data for OCIO config path. Simplified logic and error messages for better clarity.
Co-authored-by: Jakub Trllo <[email protected]>
…files-and-templated-values
iLLiCiTiT
reviewed
Aug 13, 2024
…files-and-templated-values
iLLiCiTiT
reviewed
Sep 23, 2024
iLLiCiTiT
reviewed
Sep 23, 2024
…files-and-templated-values
…files-and-templated-values
Adjust imageio config conversion function to handle changes in settings from 0.4.4 to 0.4.5, ensuring proper profile usage and plugin conversion consistency.
Simplified conditional check for ocio_config_profiles presence.
The commit updates the field name from "type" to "fallback_type" for consistency in the colorspace and settings modules.
Changed function name from '_conver_publish_plugins' to '_convert_publish_plugins' for consistency and clarity. Updated the function call accordingly in 'convert_settings_overrides'.
iLLiCiTiT
reviewed
Sep 25, 2024
Comment on lines
+17
to
+39
| for inx, profile in enumerate(ocio_config_profiles): | ||
| if profile["type"] != "product_name": | ||
| continue | ||
|
|
||
| # create new profile | ||
| new_profile = { | ||
| "type": "published_product", | ||
| "published_product": { | ||
| "product_name": profile["product_name"], | ||
| "fallback": { | ||
| "type": "builtin_path", | ||
| "builtin_path": "{BUILTIN_OCIO_ROOT}/aces_1.2/config.ocio", | ||
| }, | ||
| }, | ||
| "host_names": profile["host_names"], | ||
| "task_names": profile["task_names"], | ||
| "task_types": profile["task_types"], | ||
| "custom_path": profile["custom_path"], | ||
| "builtin_path": profile["builtin_path"], | ||
| } | ||
|
|
||
| # replace old profile with new profile | ||
| ocio_config_profiles[inx] = new_profile |
There was a problem hiding this comment.
Suggested change
| for inx, profile in enumerate(ocio_config_profiles): | |
| if profile["type"] != "product_name": | |
| continue | |
| # create new profile | |
| new_profile = { | |
| "type": "published_product", | |
| "published_product": { | |
| "product_name": profile["product_name"], | |
| "fallback": { | |
| "type": "builtin_path", | |
| "builtin_path": "{BUILTIN_OCIO_ROOT}/aces_1.2/config.ocio", | |
| }, | |
| }, | |
| "host_names": profile["host_names"], | |
| "task_names": profile["task_names"], | |
| "task_types": profile["task_types"], | |
| "custom_path": profile["custom_path"], | |
| "builtin_path": profile["builtin_path"], | |
| } | |
| # replace old profile with new profile | |
| ocio_config_profiles[inx] = new_profile | |
| for profile in ocio_config_profiles: | |
| if profile.get("type") != "product_name": | |
| continue | |
| profile["type"] = "published_product" | |
| profile["published_product"] = { | |
| "product_name": profile.pop("product_name"), | |
| "fallback": { | |
| "type": "builtin_path", | |
| "builtin_path": "{BUILTIN_OCIO_ROOT}/aces_1.2/config.ocio", | |
| }, | |
| } |
iLLiCiTiT
reviewed
Sep 25, 2024
Comment on lines
+12
to
+15
| if "ocio_config_profiles" not in imageio_overrides: | ||
| return | ||
|
|
||
| ocio_config_profiles = imageio_overrides["ocio_config_profiles"] |
There was a problem hiding this comment.
Suggested change
| if "ocio_config_profiles" not in imageio_overrides: | |
| return | |
| ocio_config_profiles = imageio_overrides["ocio_config_profiles"] | |
| ocio_config_profiles = imageio_overrides.get("ocio_config_profiles") | |
| if not ocio_config_profiles: | |
| return |
…files-and-templated-values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Improved color management distribution now includes fallback options. If no published OCIO config is found, the system will default to any predefined OCIO config path.
Additional info
Testing notes:
1.This is very difficult to test. Approach me if you can so I can help you and discuss with you the way it should work.
2. For now, just deploy to your server the settings
3. Reboot server
4. Notice that ayon+settings://core/imageio/ocio_config_profiles/0/type
Published productis having additional settings for fallback.5. Since you do not have any published product you can just type anything into the field
Product nameit does not matter what.6. In fallback section set it to build in ACES1.2
7. Open Nuke or any other DCC and see that its OCIO path is pointing to the build in path. You can observer this in AYON tray console just before the DCC is opened. Look for line with
>>> [ Setting OCIO environment to config path: <path>